gm/shadowmaps.cpp - Issue 2287553002: Moved ambient lights out of SkLight's light array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/shadowmaps.cpp

Issue 2287553002: Moved ambient lights out of SkLight's light array (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: made req changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/shadowmaps.cpp

diff --git a/gm/shadowmaps.cpp b/gm/shadowmaps.cpp

index 6c9738b2478ed70446ca461f5c364b257ab1dc84..d8682ce44fbde78a1abf0ecb8bd0ba231da360ac 100644

--- a/gm/shadowmaps.cpp

+++ b/gm/shadowmaps.cpp

@@ -74,7 +74,7 @@ public:

SkVector3::Make(0.2f, 0.1f, 1.0f)));

builder.add(SkLights::Light::MakeDirectional(SkColor3f::Make(0.4f, 0.3f, 0.2f),

SkVector3::Make(0.1f, 0.2f, 1.0f)));

- builder.add(SkLights::Light::MakeAmbient(SkColor3f::Make(0.4f, 0.4f, 0.4f)));

+ builder.setAmbientLightColor(SkColor3f::Make(0.4f, 0.4f, 0.4f));

fLights = builder.finish();

fShadowParams.fShadowRadius = 4.0f;