gm/lightingshaderbevel.cpp - Issue 2287553002: Moved ambient lights out of SkLight's light array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/lightingshaderbevel.cpp

Issue 2287553002: Moved ambient lights out of SkLight's light array (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: added ambient light calculations to Raster renderer of LightingShader Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/lightingshaderbevel.cpp

diff --git a/gm/lightingshaderbevel.cpp b/gm/lightingshaderbevel.cpp

index 9107cc6c949e65b52f705cf41e6e1b909bc9dfea..4e95c8ecc2ce424d2cc03f8c109b90aa5919143b 100644

--- a/gm/lightingshaderbevel.cpp

+++ b/gm/lightingshaderbevel.cpp

@@ -38,7 +38,7 @@ protected:

builder.add(SkLights::Light::MakeDirectional(SkColor3f::Make(1.0f, 1.0f, 1.0f),

kLightFromUpperRight));

- builder.add(SkLights::Light::MakeAmbient(SkColor3f::Make(0.2f, 0.2f, 0.2f)));

+ builder.setAmbientLightColor(SkColor3f::Make(0.2f, 0.2f, 0.2f));

fLights = builder.finish();

// fRect is assumed to be square throughout this file

« no previous file with comments | « gm/lightingshader2.cpp ('k') | gm/shadowmaps.cpp » ('j') | no next file with comments »