Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Issue 2287523002: Fixes a return type mismatch in suggestions service factory. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
index e04514422512665dc83de433afab4325fa7124d5..151b5d47b195da9564b086f11c4c442d135a09c5 100644
--- a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
@@ -120,7 +120,7 @@ IOSChromeContentSuggestionsServiceFactory::BuildServiceInstanceFor(
std::unique_ptr<ContentSuggestionsService> service =
base::MakeUnique<ContentSuggestionsService>(state);
if (state == State::DISABLED)
- return service;
+ return std::move(service);
// Create the BookmarkSuggestionsProvider.
if (base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature)) {
@@ -171,5 +171,5 @@ IOSChromeContentSuggestionsServiceFactory::BuildServiceInstanceFor(
service->RegisterProvider(std::move(ntp_snippets_service));
}
- return service;
+ return std::move(service);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698