chrome/android/java/res/layout/multiline_spinner_item.xml - Issue 2287513002: [Payments] Show name and address when selecting a CC billing address.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/multiline_spinner_item.xml

Issue 2287513002: [Payments] Show name and address when selecting a CC billing address. (Closed)

Patch Set: Fixed comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

2	3
	gone 2016/08/29 18:00:35 Might as well just remove the newline here. Might as well just remove the newline here. sebsg 2016/08/29 20:08:50 Done. Show quoted text On 2016/08/29 18:00:35, dfalcantara wrote: > Might as well just remove the newline here. Done.
3 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	8 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

9 android:id="@+id/control_spinner_drop_down"	9 style="?android:attr/spinnerItemStyle"

	10 android:singleLine="false"

10 android:layout_width="match_parent"	11 android:layout_width="match_parent"

11 android:layout_height="wrap_content"	12 android:layout_height="wrap_content"

12 android:layout_marginTop="10dp"	13 android:ellipsize="marquee"
	gone 2016/08/29 18:00:35 Does marquee do anything in this case? It's marke Does marquee do anything in this case? It's marked as being multiline, so it'll just spill over onto new lines when it gets too long. sebsg 2016/08/29 20:08:50 Done. Show quoted text On 2016/08/29 18:00:35, dfalcantara wrote: > Does marquee do anything in this case? It's marked as being multiline, so it'll > just spill over onto new lines when it gets too long. Done.
13 android:layout_marginBottom="10dp"	14 android:textAlignment="inherit"/>
	gone 2016/08/29 18:00:35 space between " and /> space between " and /> sebsg 2016/08/29 20:08:50 Done. Show quoted text On 2016/08/29 18:00:35, dfalcantara wrote: > space between " and /> Done.
14 android:background="?android:attr/selectableItemBackground"

15 android:ellipsize="end"

16 android:padding="10dp"

17 android:singleLine="true" />

OLD	NEW