cc: Remove unnecessary "default" cases from switch statements.

cc/resources/platform_color.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_PLATFORM_COLOR_H_
 #define CC_RESOURCES_PLATFORM_COLOR_H_
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "third_party/khronos/GLES2/gl2.h"
 #include "third_party/khronos/GLES2/gl2ext.h"
 #include "third_party/skia/include/core/SkTypes.h"
 
 namespace cc {
 
 class PlatformColor {
  public:
   enum SourceDataFormat {
     SOURCE_FORMAT_RGBA8,
     SOURCE_FORMAT_BGRA8
   };
 
   static SourceDataFormat Format() {
     return SK_B32_SHIFT ? SOURCE_FORMAT_RGBA8 : SOURCE_FORMAT_BGRA8;
   }
 
   // Returns the most efficient texture format for this platform.
   static GLenum BestTextureFormat(bool supports_bgra8888) {
-    GLenum texture_format = GL_RGBA;
     switch (Format()) {
-      case SOURCE_FORMAT_RGBA8:
-        break;
       case SOURCE_FORMAT_BGRA8:
         if (supports_bgra8888)
-          texture_format = GL_BGRA_EXT;
-        break;
-      default:
-        NOTREACHED();
-        break;
+          return GL_BGRA_EXT;
+        // fall-through

[danakj, 2013/08/26 15:55:39]

how about just return GL_RGBA here?

[vmpstr, 2013/08/26 16:04:26]

+1 :)

[reveman, 2013/08/26 17:16:57]

Done.

+      case SOURCE_FORMAT_RGBA8:
+        return GL_RGBA;
     }
-    return texture_format;
+    NOTREACHED();
+    return GL_RGBA;
   }
 
   // Return true if the given texture format has the same component order
   // as the color on this platform.
   static bool SameComponentOrder(GLenum texture_format) {
     switch (Format()) {
       case SOURCE_FORMAT_RGBA8:
         return texture_format == GL_RGBA;
       case SOURCE_FORMAT_BGRA8:
         return texture_format == GL_BGRA_EXT;
-      default:
-        NOTREACHED();
-        return false;
     }
+    NOTREACHED();
+    return false;
   }
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PlatformColor);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_PLATFORM_COLOR_H_