src/pdf/SkPDFUtils.h - Issue 22875037: My clang now doesn't complain about !"foo".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFUtils.h

Issue 22875037: My clang now doesn't complain about !"foo". (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFUtils.h

diff --git a/src/pdf/SkPDFUtils.h b/src/pdf/SkPDFUtils.h

index 4f54db6688b81a3c1baa14018f7cb526ba59aed7..b30821dcd926025062ad3a8c08d1df575a6e1330 100644

--- a/src/pdf/SkPDFUtils.h

+++ b/src/pdf/SkPDFUtils.h

@@ -27,7 +27,7 @@ class SkWStream;

#define NOT_IMPLEMENTED(condition, assert) \

do { \

- if (condition) { \

+ if ((bool)(condition)) { \

PRINT_NOT_IMPL("NOT_IMPLEMENTED: " #condition "\n"); \

SkDEBUGCODE(SkASSERT(!assert);) \

} \

« no previous file with comments | « src/pathops/SkPathOpsTypes.h ('k') | src/utils/SkJSON.cpp » ('j') | no next file with comments »