My clang now doesn't complain about !"foo".

tests/PathTest.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "Test.h"
 #include "SkCanvas.h"
 #include "SkPaint.h"
@@ skipping 550 matching lines @@
                 REPORTER_ASSERT(reporter, pts[0] == srcPts[0]);
                 srcPts++;
                 firstTime = false;
                 break;
             case SkPath::kLine_Verb:
                 REPORTER_ASSERT(reporter, !firstTime);
                 REPORTER_ASSERT(reporter, pts[1] == srcPts[0]);
                 srcPts++;
                 break;
             case SkPath::kQuad_Verb:
-                REPORTER_ASSERT(reporter, !"unexpected quad verb");
+                REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected quad verb");
                 break;
             case SkPath::kConic_Verb:
-                REPORTER_ASSERT(reporter, !"unexpected conic verb");
+                REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected conic verb");
                 break;
             case SkPath::kCubic_Verb:
-                REPORTER_ASSERT(reporter, !"unexpected cubic verb");
+                REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected cubic verb");
                 break;
             case SkPath::kClose_Verb:
                 REPORTER_ASSERT(reporter, !firstTime);
                 REPORTER_ASSERT(reporter, !foundClose);
                 REPORTER_ASSERT(reporter, expectClose);
                 foundClose = true;
                 break;
             case SkPath::kDone_Verb:
                 goto DONE;
         }
@@ skipping 1522 matching lines @@
                               expectedPts[numPoints + 2]);
                     numPoints += 3;
                     lastWasClose = false;
                     break;
                 case SkPath::kClose_Verb:
                     p.close();
                     haveMoveTo = false;
                     lastWasClose = true;
                     break;
                 default:
-                    SkASSERT(!"unexpected verb");
+                    SkDEBUGFAIL("unexpected verb");
             }
             expectedVerbs[numIterVerbs++] = nextVerb;
         }
 
         iter.setPath(p);
         numVerbs = numIterVerbs;
         numIterVerbs = 0;
         int numIterPts = 0;
         SkPoint lastMoveTo;
         SkPoint lastPt;
@@ skipping 32 matching lines @@
                     REPORTER_ASSERT(reporter, pts[2] == expectedPts[numIterPts + 1]);
                     REPORTER_ASSERT(reporter, pts[3] == expectedPts[numIterPts + 2]);
                     lastPt = pts[3];
                     numIterPts += 3;
                     break;
                 case SkPath::kClose_Verb:
                     REPORTER_ASSERT(reporter, pts[0] == lastMoveTo);
                     lastPt = lastMoveTo;
                     break;
                 default:
-                    SkASSERT(!"unexpected verb");
+                    SkDEBUGFAIL("unexpected verb");
             }
         }
         REPORTER_ASSERT(reporter, numIterPts == numPoints);
         REPORTER_ASSERT(reporter, numIterVerbs == numVerbs);
     }
 }
 
 static void check_for_circle(skiatest::Reporter* reporter,
                              const SkPath& path,
                              bool expectedCircle,
@@ skipping 365 matching lines @@
     test_clipped_cubic();
     test_crbug_170666();
     test_bad_cubic_crbug229478();
     test_bad_cubic_crbug234190();
     test_android_specific_behavior(reporter);
     test_path_close_issue1474(reporter);
 }
 
 #include "TestClassDef.h"
 DEFINE_TESTCLASS("Path", PathTestClass, TestPath)