My clang now doesn't complain about !"foo".

bench/GradientBench.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SkBenchmark.h"
 #include "SkBitmap.h"
 #include "SkCanvas.h"
@@ skipping 119 matching lines @@
 
 static const char* tilemodename(SkShader::TileMode tm) {
     switch (tm) {
         case SkShader::kClamp_TileMode:
             return "clamp";
         case SkShader::kRepeat_TileMode:
             return "repeat";
         case SkShader::kMirror_TileMode:
             return "mirror";
         default:
-            SkASSERT(!"unknown tilemode");
+            SkDEBUGFAIL("unknown tilemode");
             return "error";
     }
 }
 
 static const char* geomtypename(GeomType gt) {
     switch (gt) {
         case kRect_GeomType:
             return "rectangle";
         case kOval_GeomType:
             return "oval";
         default:
-            SkASSERT(!"unknown geometry type");
+            SkDEBUGFAIL("unknown geometry type");
             return "error";
     }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 class GradientBench : public SkBenchmark {
     SkString fName;
     SkShader* fShader;
     int      fCount;
@@ skipping 123 matching lines @@
 DEF_BENCH( return new GradientBench(p, kSweep_GradType); )
 DEF_BENCH( return new GradientBench(p, kSweep_GradType, gGradData[1]); )
 DEF_BENCH( return new GradientBench(p, kRadial2_GradType); )
 DEF_BENCH( return new GradientBench(p, kRadial2_GradType, gGradData[1]); )
 DEF_BENCH( return new GradientBench(p, kRadial2_GradType, gGradData[0], SkShader::kMirror_TileMode); )
 DEF_BENCH( return new GradientBench(p, kConical_GradType); )
 DEF_BENCH( return new GradientBench(p, kConical_GradType, gGradData[1]); )
 
 DEF_BENCH( return new Gradient2Bench(p, false); )
 DEF_BENCH( return new Gradient2Bench(p, true); )