chromeos: Notify observers after display power changes.

chromeos: Notify observers after display power changes.

This updates OutputConfigurator::SetDisplayPower() to notify
observers after the power state is changed. Otherwise, Ash
gets confused when exiting docked mode.

BUG=274018
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218164

[Daniel Erat, 2013-08-16 00:51:45]

https://codereview.chromium.org/22875019/diff/1/chromeos/display/output_confi...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/22875019/diff/1/chromeos/display/output_confi...
chromeos/display/output_configurator.cc:262: NotifyOnDisplayChanged();
I don't think that we need to notify about failures, since power state changes
aren't Chrome-initiated (and only change the DisplayPowerState instead of the
OutputState). Let me know if I'm wrong, though.

[Daniel Erat, 2013-08-16 03:44:15]

PTAL

[oshima, 2013-08-16 13:52:05]

https://codereview.chromium.org/22875019/diff/5001/chromeos/display/output_co...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/22875019/diff/5001/chromeos/display/output_co...
chromeos/display/output_configurator.cc:286: new_state, power_state_, outputs);
new_state and output_state_ can be different when it successfully
swtiched to software mirroring mode. Can't we simply pass success
to NotifyObserver rather than state?

[Daniel Erat, 2013-08-16 15:51:15]

make NotifyObservers take a success argument

[Daniel Erat, 2013-08-16 15:52:31]

Please ignore PS3; it's diffed against trunk instead of against
https://codereview.chromium.org/22871010/.

https://codereview.chromium.org/22875019/diff/5001/chromeos/display/output_co...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/22875019/diff/5001/chromeos/display/output_co...
chromeos/display/output_configurator.cc:286: new_state, power_state_, outputs);
On 2013/08/16 13:52:05, oshima wrote:
> new_state and output_state_ can be different when it successfully
> swtiched to software mirroring mode. Can't we simply pass success
> to NotifyObserver rather than state?

Done. (We also need to pass the state so we can include it in failure
notifications.)

[oshima, 2013-08-16 16:19:14]

lgtm with nits

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator.cc:255: new_state, power_state, outputs)) {
success = EnterState...;
if (success && power_state_ != DISPLAY_POWER_ALL_OFF)
   delegate_->FoceDPRMSOn();

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
File chromeos/display/output_configurator_unittest.cc (right):

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator_unittest.cc:202: ~TestObserver() {
virtual

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator_unittest.cc:227: virtual void
OnDisplayModeChangeFailed(OutputState failed_new_state) {
OVERRIDE

[Daniel Erat, 2013-08-16 16:26:05]

address nits

[Daniel Erat, 2013-08-16 16:42:16]

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator.cc:255: new_state, power_state, outputs)) {
On 2013/08/16 16:19:14, oshima wrote:
> success = EnterState...;
> if (success && power_state_ != DISPLAY_POWER_ALL_OFF)
>    delegate_->FoceDPRMSOn();
> 

Done.

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
File chromeos/display/output_configurator_unittest.cc (right):

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator_unittest.cc:202: ~TestObserver() {
On 2013/08/16 16:19:14, oshima wrote:
> virtual

Done.

https://codereview.chromium.org/22875019/diff/13001/chromeos/display/output_c...
chromeos/display/output_configurator_unittest.cc:227: virtual void
OnDisplayModeChangeFailed(OutputState failed_new_state) {
On 2013/08/16 16:19:14, oshima wrote:
> OVERRIDE

Done.

[Daniel Erat, 2013-08-16 21:05:28]

merge

[commit-bot: I haz the power, 2013-08-16 21:06:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/22875019/25001

[commit-bot: I haz the power, 2013-08-16 21:53:41]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-16 22:04:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/22875019/25001

[commit-bot: I haz the power, 2013-08-17 13:32:22]

Change committed as 218164