LayoutTests/fast/dom/HTMLLinkElement/prefetch-detached.html - Issue 22875013: Make several DOMImplementation API arguments mandatory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLLinkElement/prefetch-detached.html

Issue 22875013: Make several DOMImplementation API arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Keep hasFeature() as it was Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <body>	1 <body>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5 </script>	5 </script>

6 <html>	6 <html>

7 <p>This test passes if it doesn't crash.</p>	7 <p>This test passes if it doesn't crash.</p>

8 <div id="frag"></div>	8 <div id="frag"></div>

9 <script>	9 <script>

10 // Fun with innerHTML.	10 // Fun with innerHTML.

11 document.getElementById('frag').innerHTML = '<link href="prefetch.link" rel="pre fetch">';	11 document.getElementById('frag').innerHTML = '<link href="prefetch.link" rel="pre fetch">';

12	12

13 // Fun with detached documents.	13 // Fun with detached documents.

14 var doc = document.implementation.createDocument('application/html+xml');	14 var doc = document.implementation.createDocument('application/html+xml', 'html') ;
	arv (Not doing code reviews) 2013/08/16 13:33:27 I'm not sure what the crash was but the first argu I'm not sure what the crash was but the first argument should be the namespace and not the mime type. I don't think it is worth changing
15 var lnk = doc.createElement('link');	15 var lnk = doc.createElement('link');

16 lnk.setAttribute('rel', 'prefetch');	16 lnk.setAttribute('rel', 'prefetch');

17 lnk.setAttribute('href', 'prefetch.link');	17 lnk.setAttribute('href', 'prefetch.link');

18 doc.documentElement.appendChild(lnk);	18 doc.documentElement.appendChild(lnk);

19 </script>	19 </script>

20 </html>	20 </html>

OLD	NEW