LayoutTests/fast/css/zoom-on-unattached.html - Issue 22875013: Make several DOMImplementation API arguments mandatory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/zoom-on-unattached.html

Issue 22875013: Make several DOMImplementation API arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Keep hasFeature() as it was Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)

3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4	4

5 root = document.createElement("body");	5 root = document.createElement("body");

6 d = document.implementation.createDocument();	6 d = document.implementation.createDocument("", "");
	arv (Not doing code reviews) 2013/08/16 13:33:27 FYI, (null, "") is a better default FYI, (null, "") is a better default do-not-use 2013/08/16 13:47:03 Right, my bad, I misread the spec. Show quoted text On 2013/08/16 13:33:27, arv wrote: > FYI, (null, "") is a better default Right, my bad, I misread the spec.
7 d.adoptNode(root);	7 d.adoptNode(root);

8 node = document.createElement("title");	8 node = document.createElement("title");

9 root.appendChild(node);	9 root.appendChild(node);

10 node.setAttribute("style", "zoom:document;")	10 node.setAttribute("style", "zoom:document;")

11 node.appendChild(node.cloneNode());	11 node.appendChild(node.cloneNode());

12 </script>	12 </script>

13 <body>	13 <body>

14 This test passes if it does not crash.	14 This test passes if it does not crash.

15 </body>	15 </body>

OLD	NEW