Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 22875006: Optimize png files in chrome/app/theme/default_200_percent (Closed)

Created:
7 years, 4 months ago by oshima
Modified:
7 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Optimize png files in chrome/app/theme/default_200_percent -o1 is used because some of files are too big to process in time. I'll ether black-list these files or add threshold to skip applying o2. ./build/sanitize-png-files.sh chrome/app/theme/default_200_percent Processed 14 files (out of 746 files) in 01:03:25s Result : 80573 => 70634 bytes (9939 bytes : 12 %) BUG=271299 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/default_200_percent/common/allowed_midi.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/audio_equalizer_column.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/autofill_generated_card.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/autofill_tooltip_icon.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/autofill_tooltip_icon_hover.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/blocked_midi.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/browser_tools_bar.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/infobar_midi.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/payment_checkmark.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/wallet_logo.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/supervised_illsutration_done.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/supervised_illustration_start.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/technical_error.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/screen_capture_notification_grip.png View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
7 years, 4 months ago (2013-08-12 19:24:38 UTC) #1
oshima
Committed patchset #1 manually as r217052 (presubmit successful).
7 years, 4 months ago (2013-08-12 19:24:59 UTC) #2
msw
7 years, 4 months ago (2013-08-12 19:56:52 UTC) #3
Message was sent while issue was closed.
LGTM. -o2 might not even save much size on the total ~70kb so you probably don't
need to worry about that too much, but maybe adjusting the LARGE_FILE_THRESHOLD
(or making a commandline option to tweak it) would help. Perhaps we could even
automatically measure the time for a single random_huffman_table_trial and
adjust the number of subsequent trials based on that so no file's compression
takes more than a few seconds. But again it's not worth too much effort right
now.

Powered by Google App Engine
This is Rietveld 408576698