Stop ResourceCallback from being an on-heap class

Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
Committed: https://crrev.com/9dcf57878d47393d7b3bfd5aa501b5dc4cf0c445
Cr-Commit-Position: refs/heads/master@{#414989}

[yhirano, 2016-08-26 13:40:33]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 13:41:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-26 13:42:22]

Description was changed from

==========
Avoid instantiating the static ResourceCallback in the pre-finalization step.

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As it is an on-heap object, we are not allowed to
instantiate it in the pre-finalization step.

This CL calls the function in Resource constructor to avoid that.

BUG=587663
==========

to

==========
Avoid instantiating the ResourceCallback singleton in the pre-finalization step

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As it is an on-heap object, we are not allowed to
instantiate it in the pre-finalization step.

This CL calls the function in Resource constructor to avoid that.

BUG=587663
==========

[yhirano, 2016-08-26 13:42:22]

yhirano@chromium.org changed reviewers:
+ haraken@chromium.org

[yhirano, 2016-08-26 13:43:39]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 13:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-26 13:51:03]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 13:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-26 13:53:54]

Description was changed from

==========
Avoid instantiating the ResourceCallback singleton in the pre-finalization step

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As it is an on-heap object, we are not allowed to
instantiate it in the pre-finalization step.

This CL calls the function in Resource constructor to avoid that.

BUG=587663
==========

to

==========
Stop ResourceCallback from being an on-heap class.

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

[yhirano, 2016-08-26 13:54:09]

Description was changed from

==========
Stop ResourceCallback from being an on-heap class.

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

to

==========
Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

[yhirano, 2016-08-26 13:59:32]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 13:59:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:26:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-08-27 00:36:12]

LGTM

[yhirano, 2016-08-29 04:34:11]

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:248: // Oilpan + LSan: as the
callbackHandler() singleton is used by Resource
haraken@: Sorry I forgot to ask, I don't know if we should keep this comment and
LEAK_SANITIZER_DISABLED_SCOPE. Can you tell me?

[haraken, 2016-08-29 04:37:03]

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:248: // Oilpan + LSan: as the
callbackHandler() singleton is used by Resource
On 2016/08/29 04:34:11, yhirano wrote:
> haraken@: Sorry I forgot to ask, I don't know if we should keep this comment
and
> LEAK_SANITIZER_DISABLED_SCOPE. Can you tell me?

This is a oilpan & DISABLE_STATIC_LOCAL specific thing. So you can just remove
the comment and the scope.

[yhirano, 2016-08-29 04:39:48]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 04:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-29 04:40:46]

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2287483003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:248: // Oilpan + LSan: as the
callbackHandler() singleton is used by Resource
On 2016/08/29 04:37:02, haraken wrote:
> On 2016/08/29 04:34:11, yhirano wrote:
> > haraken@: Sorry I forgot to ask, I don't know if we should keep this comment
> and
> > LEAK_SANITIZER_DISABLED_SCOPE. Can you tell me?
> 
> This is a oilpan & DISABLE_STATIC_LOCAL specific thing. So you can just remove
> the comment and the scope.

Thanks!

[yhirano, 2016-08-29 04:41:02]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-08-29 04:41:02]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-08-29 04:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2287483003/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-08-29 04:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 05:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:41:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2016-08-29 06:12:57]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-29 06:13:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 07:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 07:06:39]

Exceeded global retry quota

[yhirano, 2016-08-29 07:46:59]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-29 07:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 08:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 08:54:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yhirano, 2016-08-29 08:57:21]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-29 08:57:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:35:16]

Description was changed from

==========
Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

to

==========
Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

[commit-bot: I haz the power, 2016-08-29 09:35:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-29 09:37:05]

Description was changed from

==========
Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663
==========

to

==========
Stop ResourceCallback from being an on-heap class

The first ResourceCallback::callbackHandler() call instantiates the
ResourceCallback singleton. As we call it in the pre-finalization
step, it should not be an on-heap class.

BUG=587663

Committed: https://crrev.com/9dcf57878d47393d7b3bfd5aa501b5dc4cf0c445
Cr-Commit-Position: refs/heads/master@{#414989}
==========

[commit-bot: I haz the power, 2016-08-29 09:37:06]

Patchset 5 (id:??) landed as
https://crrev.com/9dcf57878d47393d7b3bfd5aa501b5dc4cf0c445
Cr-Commit-Position: refs/heads/master@{#414989}