Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2287443003:
Remove use of stl_util in rtc. (Closed)
|
Created:
4 years, 3 months ago by Avi (use Gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove use of stl_util in rtc.
BUG=555865
Committed: https://crrev.com/07b17a8e40eb4af58b716e5dc1eba449f11ff920
Cr-Commit-Position: refs/heads/master@{#415327}
Patch Set 1 #Patch Set 2 : all of stl #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove a use of stl_util's STLDeleteContainerPairFirstPointers. BUG=555865 ========== to ========== Remove use of stl_util. BUG=555865 ==========
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove use of stl_util. BUG=555865 ========== to ========== Remove use of stl_util in rtc. BUG=555865 ==========
avi@chromium.org changed reviewers: + posciak@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + wuchengli@chromium.org
Can I get any OWNER to look at this?
avi@chromium.org changed reviewers: + perkj@chromium.org, tommi@chromium.org
Adding even more OWNERs. Can I please get a review here?
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove use of stl_util in rtc. BUG=555865 ========== to ========== Remove use of stl_util in rtc. BUG=555865 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove use of stl_util in rtc. BUG=555865 ========== to ========== Remove use of stl_util in rtc. BUG=555865 Committed: https://crrev.com/07b17a8e40eb4af58b716e5dc1eba449f11ff920 Cr-Commit-Position: refs/heads/master@{#415327} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/07b17a8e40eb4af58b716e5dc1eba449f11ff920 Cr-Commit-Position: refs/heads/master@{#415327} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
