Add setup for integration tests in FakeChromeIdentityService.

Add setup for integration tests in FakeChromeIdentityService.

BUG=640623
Committed: https://crrev.com/353e119c15e6ee7edf5fe4f5645bf3d2255d0cc3
Cr-Commit-Position: refs/heads/master@{#415315}

[bzanotti, 2016-08-29 15:45:41]

bzanotti@chromium.org changed reviewers:
+ msarda@chromium.org

[bzanotti, 2016-08-29 15:45:42]

Please take a look.

[msarda, 2016-08-30 12:23:08]

lgtm

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
(right):

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:25: //
Token and expiration date. It should be larger than typical test
These local variables are only used inside the block. Move them inside the
block.

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:32: //
GetAccessToken is normally an asynchronous operation (that requires some
Nit: Here and for the comments below:
s/GetAccessToken/|GetAccessToken|

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:57:
gaia::CanonicalizeEmail(base::SysNSStringToUTF8(identity.userEmail))));
Nit: Add blank line as otherwise reading this on the code review tool is hard.

[bzanotti, 2016-08-30 12:36:34]

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
(right):

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:25: //
Token and expiration date. It should be larger than typical test
On 2016/08/30 12:23:08, msarda wrote:
> These local variables are only used inside the block. Move them inside the
> block.

Done.

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:32: //
GetAccessToken is normally an asynchronous operation (that requires some
On 2016/08/30 12:23:08, msarda wrote:
> Nit: Here and for the comments below:
> s/GetAccessToken/|GetAccessToken|

Done.

https://codereview.chromium.org/2287383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm:57:
gaia::CanonicalizeEmail(base::SysNSStringToUTF8(identity.userEmail))));
On 2016/08/30 12:23:08, msarda wrote:
> Nit: Add blank line as otherwise reading this on the code review tool is hard.

Done.

[bzanotti, 2016-08-30 12:37:43]

bzanotti@chromium.org changed reviewers:
+ rogerta@chromium.org, rohitrao@chromium.org

[bzanotti, 2016-08-30 12:37:44]

Rohit: Please do an OWNERS review for the DEPS file.

Roger: Please do an OWNERS review for the addition of google_apis/gaia in the
DEPS file.

[rohitrao (ping after 24h), 2016-08-30 12:42:33]

lgtm

[Roger Tawa OOO till Jul 10th, 2016-08-30 15:47:13]

lgtm DEPS

[bzanotti, 2016-08-30 15:47:31]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2016-08-30 15:47:31]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org,
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2287383002/#ps40001
(title: "Fix callback in FakeGetAccessToken")

[commit-bot: I haz the power, 2016-08-30 15:47:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:25:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 16:27:29]

Description was changed from

==========
Add setup for integration tests in FakeChromeIdentityService.

BUG=640623
==========

to

==========
Add setup for integration tests in FakeChromeIdentityService.

BUG=640623

Committed: https://crrev.com/353e119c15e6ee7edf5fe4f5645bf3d2255d0cc3
Cr-Commit-Position: refs/heads/master@{#415315}
==========

[commit-bot: I haz the power, 2016-08-30 16:27:30]

Patchset 3 (id:??) landed as
https://crrev.com/353e119c15e6ee7edf5fe4f5645bf3d2255d0cc3
Cr-Commit-Position: refs/heads/master@{#415315}