Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2287363002: Subzero: Fix the LLVM trunk build. (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix the LLVM trunk build. The original Ice::Inst needed a bit of template specialization so that llvm::ilist<Ice::Inst> methods wouldn't try to invoke private/deleted ctor/dtor methods. The Subzero code copied a pattern fairly widely used in LLVM. Recently, LLVM improved ilist<> so that this specialization is no longer needed. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8b21cc589f0cc01344a6a772c97c1f24a40718cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/IceInst.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 3 months ago (2016-08-29 14:15:15 UTC) #3
John
lgtm
4 years, 3 months ago (2016-08-29 14:45:36 UTC) #4
Jim Stichnoth
4 years, 3 months ago (2016-08-29 17:15:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b21cc589f0cc01344a6a772c97c1f24a40718cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698