Cross shadow DOM boundaries for :-webkit-full-screen-ancestor

Cross shadow DOM boundaries for :-webkit-full-screen-ancestor

BUG=631245
Committed: https://crrev.com/a2a0e98d3249fe12469ea5ede7658b02c88113e9
Cr-Commit-Position: refs/heads/master@{#416267}

[foolip, 2016-08-29 13:35:56]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-08-29 13:49:07]

foolip@chromium.org changed reviewers:
+ eae@chromium.org, esprehn@chromium.org, kochi@chromium.org

[foolip, 2016-08-29 13:49:08]

PTAL. This fixes the problem, but I'm not so sure it's a good idea. The assert
mentioned in the issue is a reminder that LayoutFullScreen is terrible and I'm
not sure if trying to fix it for shadow DOM might open up new issues. WDYAT?

[commit-bot: I haz the power, 2016-08-29 15:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:51:05]

Dry run: This issue passed the CQ dry run.

[kochi, 2016-08-30 15:28:45]

It sounds this issue is a blocker for crbug.com/627792 or crbug.com/535164, so
I'm welcome to this change, in terms of
Shadow DOM.

But I'm not familiar with LayoutFullScreen so would like to defer
other reviewers for that part.

[dglazkov, 2016-08-30 15:33:23]

Should there be a spec bug?

[esprehn, 2016-08-30 22:20:13]

lgtm

[esprehn, 2016-08-30 22:21:05]

On 2016/08/30 at 15:33:23, dglazkov wrote:
> Should there be a spec bug?

This whole concept of full-screen-ancestor and the CSS crazy around it should go
away with top layer. The spec doesn't talk about any of it, it's an
(unfortunate) implementation detail of the WebKit full screen system.

[foolip, 2016-09-02 13:43:58]

On 2016/08/30 22:21:05, esprehn wrote:
> On 2016/08/30 at 15:33:23, dglazkov wrote:
> > Should there be a spec bug?
> 
> This whole concept of full-screen-ancestor and the CSS crazy around it should
go
> away with top layer. The spec doesn't talk about any of it, it's an
> (unfortunate) implementation detail of the WebKit full screen system.

Yep, that's right. The spec should however change around Shadow DOM so that
document.fullscreenElement can't point to an element inside a shadow tree but
rather to the shadow host, and that ShadowRoot then has its own
fullscreenElement. That's tracked here:
https://github.com/w3c/webcomponents/issues/180
https://github.com/whatwg/fullscreen/issues/42

For now, I'm going to land this since it does fix Twitter video embeds and my
ETA on relanding top layer is still fuzzy. At the first sign of trouble I'll
revert this though.

[foolip, 2016-09-02 13:44:04]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-09-02 13:44:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 15:28:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 15:30:29]

Description was changed from

==========
Cross shadow DOM boundaries for :-webkit-full-screen-ancestor

BUG=631245
==========

to

==========
Cross shadow DOM boundaries for :-webkit-full-screen-ancestor

BUG=631245

Committed: https://crrev.com/a2a0e98d3249fe12469ea5ede7658b02c88113e9
Cr-Commit-Position: refs/heads/master@{#416267}
==========

[commit-bot: I haz the power, 2016-09-02 15:30:29]

Patchset 1 (id:??) landed as
https://crrev.com/a2a0e98d3249fe12469ea5ede7658b02c88113e9
Cr-Commit-Position: refs/heads/master@{#416267}