Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: components/policy/core/common/cloud/cloud_policy_client_unittest.cc

Issue 2287343004: All DCP manager tests that enroll/register are tested with all auths. (Closed)
Patch Set: Slight renaming. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_client_unittest.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
index b2f479c180987e3cf429f0787ebcb9b7427de488..afbf33a2ed0016ab0677ce84a9cce0c360400b32 100644
--- a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
+++ b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
@@ -111,7 +111,7 @@ class CloudPolicyClientTest : public testing::Test {
em::CertificateBasedDeviceRegisterRequest* cert_based_register_request =
cert_based_registration_request_.mutable_cert_based_register_request();
- fake_signing_service_.SignRegistrationData(&data,
+ fake_signing_service_.SignDataSynchronously(data.SerializeAsString(),
cert_based_register_request->mutable_signed_request());
em::PolicyFetchRequest* policy_fetch_request =
@@ -360,6 +360,8 @@ class CloudPolicyClientTest : public testing::Test {
std::unique_ptr<CloudPolicyClient> client_;
// Pointer to the client's request context.
scoped_refptr<net::URLRequestContextGetter> request_context_;
+
+ private:
pastarmovj 2016/08/30 08:55:03 nit: nothing in here? Either remove or populate :)
The one and only Dr. Crash 2016/08/30 17:09:29 Removed.
};
TEST_F(CloudPolicyClientTest, Init) {

Powered by Google App Engine
This is Rietveld 408576698