All DCP manager tests that enroll/register are tested with all auths.

All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187, 641447
TEST=unit_tests

Committed: https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d
Cr-Commit-Position: refs/heads/master@{#415574}

[The one and only Dr. Crash, 2016-08-30 01:13:00]

drcrash@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[The one and only Dr. Crash, 2016-08-30 05:49:14]

Description was changed from

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=641447
TEST=unit_tests
==========

to

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests
==========

[pastarmovj, 2016-08-30 08:55:03]

lgtm -ing already now to not delay the change but please consider the request in
d_c_p_i.h.

https://codereview.chromium.org/2287343004/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_cloud_policy_initializer.h (right):

https://codereview.chromium.org/2287343004/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_initializer.h:156:
std::unique_ptr<SigningService> default_signing_service_;
Since there is no way of going back to the default once it is changed with the
setter I think it might be better to simply have the signing_service be a
unique_ptr and simply reset it with whatever comes in through the setter. The
ownership of the service will then be to the DCPI class at all times.
Alternatively make this a parameter to the constructor. WDYT?

https://codereview.chromium.org/2287343004/diff/60001/components/policy/core/...
File components/policy/core/common/cloud/cloud_policy_client_unittest.cc
(right):

https://codereview.chromium.org/2287343004/diff/60001/components/policy/core/...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:364:
private:
nit: nothing in here? Either remove or populate :)

[The one and only Dr. Crash, 2016-08-30 17:09:29]

https://codereview.chromium.org/2287343004/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_cloud_policy_initializer.h (right):

https://codereview.chromium.org/2287343004/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_initializer.h:156:
std::unique_ptr<SigningService> default_signing_service_;
On 2016/08/30 08:55:03, pastarmovj wrote:
> Since there is no way of going back to the default once it is changed with the
> setter I think it might be better to simply have the signing_service be a
> unique_ptr and simply reset it with whatever comes in through the setter. The
> ownership of the service will then be to the DCPI class at all times.
> Alternatively make this a parameter to the constructor. WDYT?

Sure. Done.

https://codereview.chromium.org/2287343004/diff/60001/components/policy/core/...
File components/policy/core/common/cloud/cloud_policy_client_unittest.cc
(right):

https://codereview.chromium.org/2287343004/diff/60001/components/policy/core/...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:364:
private:
On 2016/08/30 08:55:03, pastarmovj wrote:
> nit: nothing in here? Either remove or populate :)

Removed.

[The one and only Dr. Crash, 2016-08-30 17:09:34]

The CQ bit was checked by drcrash@chromium.org

[The one and only Dr. Crash, 2016-08-30 17:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2287343004/#ps80001
(title: "Removed default_attestion_flow")

[commit-bot: I haz the power, 2016-08-30 17:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:48:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[The one and only Dr. Crash, 2016-08-30 19:25:44]

The CQ bit was checked by drcrash@chromium.org

[The one and only Dr. Crash, 2016-08-30 19:25:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2287343004/#ps100001
(title: "Fixed tests deriving from a parametrized test to also be
parameterized.")

[commit-bot: I haz the power, 2016-08-30 19:26:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:30:25]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[The one and only Dr. Crash, 2016-08-31 04:42:42]

The CQ bit was checked by drcrash@chromium.org

[The one and only Dr. Crash, 2016-08-31 04:42:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2287343004/#ps120001
(title: "That time when I had to remerge everything...")

[commit-bot: I haz the power, 2016-08-31 04:43:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 06:30:05]

Description was changed from

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests
==========

to

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests
==========

[commit-bot: I haz the power, 2016-08-31 06:30:06]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-31 06:31:53]

Description was changed from

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests
==========

to

==========
All DCP manager tests that enroll/register are tested with all auths.

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests

Committed: https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d
Cr-Commit-Position: refs/heads/master@{#415574}
==========

[commit-bot: I haz the power, 2016-08-31 06:31:54]

Patchset 7 (id:??) landed as
https://crrev.com/f71058accb8d57221145dfb2c34769244d6cc54d
Cr-Commit-Position: refs/heads/master@{#415574}

[battre, 2016-08-31 11:46:49]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2302443002/ by battre@chromium.org.

The reason for reverting is: Reverting due to use after free. See
http://crbug.com/624187#c28.