Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: src/heap/heap.h

Issue 2287343002: [heap] Integrate embedder heap tracer into incremental marking (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index b9b058c1cdb846a4a9a4158b7286104b4f3373d5..e0d20a032fb87bf97848b38402246b36529d9685 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -763,14 +763,6 @@ class Heap {
// Returns false if not able to reserve.
bool ReserveSpace(Reservation* reservations, List<Address>* maps);
- void SetEmbedderHeapTracer(EmbedderHeapTracer* tracer);
-
- bool UsingEmbedderHeapTracer();
-
- void TracePossibleWrapper(JSObject* js_object);
-
- void RegisterExternallyReferencedObject(Object** object);
-
//
// Support for the API.
//
@@ -1174,6 +1166,18 @@ class Heap {
IncrementalMarking* incremental_marking() { return incremental_marking_; }
// ===========================================================================
+ // Embedder heap tracer support. =============================================
+ // ===========================================================================
+
+ void SetEmbedderHeapTracer(EmbedderHeapTracer* tracer);
+
+ bool UsingEmbedderHeapTracer();
+
+ void TracePossibleWrapper(JSObject* js_object);
+
+ void RegisterExternallyReferencedObject(Object** object);
+
+ // ===========================================================================
// External string table API. ================================================
// ===========================================================================
@@ -1588,6 +1592,10 @@ class Heap {
return current_gc_flags_ & kFinalizeIncrementalMarkingMask;
}
+ // Checks whether both, the internal marking deque, and the embedder provided
+ // one are empty. Avoid in fast path as it potentially calls through the API.
+ bool MarkingDequesAreEmpty();
+
void PreprocessStackTraces();
// Checks whether a global GC is necessary
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698