Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2287343002:
[heap] Integrate embedder heap tracer into incremental marking (Closed)
|
Created:
4 years, 3 months ago by Michael Lippautz Modified:
4 years, 3 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Integrate embedder heap tracer into incremental marking
- Respect a deadline when processing wrappers during incremental marking, i.e.,
don't force completetion on each individual step
- Only finalize when both, the internal marking deque and wrappers, are
processed
Some results (twitter using --enable-blink-features=TraceWrappables)
=== BEFORE ===
incremental_wrapper_tracing_longest_step
len: 13
min: 0.0
---> max: 6.6
---> avg: 3.83846153846
[0,5[: 7
[5,10[: 6
mark.wrapper_tracing
len: 13
min: 0.0
max: 2.0 (non-incremental MC)
avg: 0.153846153846
[0,5[: 13
=== AFTER ===
incremental_wrapper_tracing_longest_step
len: 8
min: 0.0
---> max: 1.1
---> avg: 0.8875
[0,5[: 8
mark.wrapper_tracing (not excluding non-incremental MC)
len: 8
min: 0.0
max: 2.5 (non-incremental MC)
avg: 0.3125
[0,5[: 8
BUG=chromium:468240
R=ulan@chromium.org
Committed: https://crrev.com/998c9285ea4c42d0580c218449c84c02bf2d5d15
Cr-Commit-Position: refs/heads/master@{#39041}
Patch Set 1 #Patch Set 2 : Improvements #Patch Set 3 : Fixes and rebase #
Total comments: 4
Patch Set 4 : Addressed comments #
Messages
Total messages: 26 (19 generated)
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking BUG= ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed BUG= ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed BUG= ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results: === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results: === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG= ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
PTAL Any reason why the EmbedderHeapTracer* lives in MC? We are using from all over the place (heap, MC, incremental marking).
lgtm https://codereview.chromium.org/2287343002/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2287343002/diff/40001/src/heap/heap.cc#newcod... src/heap/heap.cc:4191: mark_compact_collector()->marking_deque()->IsEmpty()))) { I think we should replace this too. https://codereview.chromium.org/2287343002/diff/40001/src/heap/incremental-ma... File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2287343002/diff/40001/src/heap/incremental-ma... src/heap/incremental-marking.cc:1223: const double wrapper_dl = Let's spell out "deadline" comptely :)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing (not excluding non-incremental MC) len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 max: 6.6 avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing (not excluding non-incremental MC) len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 max: 1.1 avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing (not excluding non-incremental MC) len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing (not excluding non-incremental MC) len: 13 min: 0.0 max: 2.0 avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline ehen processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion on each individual step - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
On 2016/08/31 at 09:16:43, mlippautz wrote: > PTAL > > Any reason why the EmbedderHeapTracer* lives in MC? We are using from all over the place (heap, MC, incremental marking). Because at the times past it was only used in MC :) Feel free to move it where it makes sense now.
https://codereview.chromium.org/2287343002/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2287343002/diff/40001/src/heap/heap.cc#newcod... src/heap/heap.cc:4191: mark_compact_collector()->marking_deque()->IsEmpty()))) { On 2016/08/31 09:29:57, ulan wrote: > I think we should replace this too. Done. https://codereview.chromium.org/2287343002/diff/40001/src/heap/incremental-ma... File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2287343002/diff/40001/src/heap/incremental-ma... src/heap/incremental-marking.cc:1223: const double wrapper_dl = On 2016/08/31 09:29:57, ulan wrote: > Let's spell out "deadline" comptely :) Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2287343002/#ps60001 (title: "Addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion on each individual step - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion on each individual step - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion on each individual step - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org ========== to ========== [heap] Integrate embedder heap tracer into incremental marking - Respect a deadline when processing wrappers during incremental marking, i.e., don't force completetion on each individual step - Only finalize when both, the internal marking deque and wrappers, are processed Some results (twitter using --enable-blink-features=TraceWrappables) === BEFORE === incremental_wrapper_tracing_longest_step len: 13 min: 0.0 ---> max: 6.6 ---> avg: 3.83846153846 [0,5[: 7 [5,10[: 6 mark.wrapper_tracing len: 13 min: 0.0 max: 2.0 (non-incremental MC) avg: 0.153846153846 [0,5[: 13 === AFTER === incremental_wrapper_tracing_longest_step len: 8 min: 0.0 ---> max: 1.1 ---> avg: 0.8875 [0,5[: 8 mark.wrapper_tracing (not excluding non-incremental MC) len: 8 min: 0.0 max: 2.5 (non-incremental MC) avg: 0.3125 [0,5[: 8 BUG=chromium:468240 R=ulan@chromium.org Committed: https://crrev.com/998c9285ea4c42d0580c218449c84c02bf2d5d15 Cr-Commit-Position: refs/heads/master@{#39041} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/998c9285ea4c42d0580c218449c84c02bf2d5d15 Cr-Commit-Position: refs/heads/master@{#39041} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
