Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2287333002: MIPS: Fix Neg_s and Neg_d for loongson and r1 (Closed)

Created:
4 years, 3 months ago by miran.karic
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix Neg_s and Neg_d for loongson and r1 For arch variants loongson and r1 neg instruction does not change the sign for NaN-like operands, the same as r2 neg. This fix adjusts macro assembler Neg_s and Neg_d arch variant logic so the correct code would be generated for loongson and r1. BUG= Committed: https://crrev.com/1ceb9aeca68829d609ffc2a6283d966f7ec5b658 Cr-Commit-Position: refs/heads/master@{#39007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M src/mips/macro-assembler-mips.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miran.karic
4 years, 3 months ago (2016-08-29 12:40:04 UTC) #2
balazs.kilvady
LGTM
4 years, 3 months ago (2016-08-30 10:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287333002/1
4 years, 3 months ago (2016-08-30 11:20:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 11:43:46 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:44:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ceb9aeca68829d609ffc2a6283d966f7ec5b658
Cr-Commit-Position: refs/heads/master@{#39007}

Powered by Google App Engine
This is Rietveld 408576698