core/fxge/agg/fx_agg_driver.cpp - Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/agg/fx_agg_driver.cpp

Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@moar_better_constness

Patch Set: Casts, Casts, New -> Emplace. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxge/agg/fx_agg_driver.cpp

diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp

index cf0fd90917d364b4a6ecfbb56e2b0894d010007d..9db10ac3c679c37e26d77226e05581337ca8a8c3 100644

--- a/core/fxge/agg/fx_agg_driver.cpp

+++ b/core/fxge/agg/fx_agg_driver.cpp

@@ -528,10 +528,7 @@ void CFX_AggDeviceDriver::SetClipMask(agg::rasterizer_scanline_aa& rasterizer) {

rasterizer.max_x() + 1, rasterizer.max_y() + 1);

path_rect.Intersect(m_pClipRgn->GetBox());

CFX_DIBitmapRef mask;

- CFX_DIBitmap* pThisLayer = mask.New();

- if (!pThisLayer) {

- return;

- }

+ CFX_DIBitmap* pThisLayer = mask.Emplace();

pThisLayer->Create(path_rect.Width(), path_rect.Height(), FXDIB_8bppMask);

pThisLayer->Clear(0);

agg::rendering_buffer raw_buf(pThisLayer->GetBuffer(), pThisLayer->GetWidth(),

« no previous file with comments | « core/fxcrt/include/cfx_count_ref.h ('k') | core/fxge/ge/cfx_cliprgn.cpp » ('j') | no next file with comments »