core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@moar_better_constness

Patch Set: Casts, Casts, New -> Emplace. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index 6fa1df26cd87dd3d1d95013403ed0cac8c4ce10d..e261ce5bb5a32a513be5ec87a079b9c972092726 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -688,7 +688,7 @@ void CPDF_ContentParser::Start(CPDF_Form* pForm,

CPDF_Path ClipPath;

if (pBBox) {

form_bbox = pBBox->GetRect();

- ClipPath.New();

+ ClipPath.Emplace();

ClipPath.AppendRect(form_bbox.left, form_bbox.bottom, form_bbox.right,

form_bbox.top);

ClipPath.Transform(&form_matrix);

« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_page/include/cpdf_textstatedata.h » ('j') | no next file with comments »