Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2287283002: Convert editing/inserting/paragraph-separator-0[123].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/paragraph-separator-0[123].html to use w3c test harness This patch converts "editing/inserting/paragraph-separator-0[123].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "insert_paragraph_separator.html" since these files are in same patch at beginning. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/07fbfac91e8b5f2160a041f16c9c57ccf1dcd613 Cr-Commit-Position: refs/heads/master@{#415198}

Patch Set 1 : 2016-08-29T18:27:20 #

Total comments: 2

Patch Set 2 : 2016-08-30T13:39:16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -297 lines) Patch
A third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/paragraph-separator-01.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/paragraph-separator-02.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/paragraph-separator-03.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-01-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-02-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-03-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/inserting/paragraph-separator-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-01-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-02-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-03-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-01-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-02-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-03-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-29 09:34:05 UTC) #5
yoichio
lgtm https://codereview.chromium.org/2287283002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html File third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html (right): https://codereview.chromium.org/2287283002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html#newcode19 third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html:19: // A Testt for a bug in the ...
4 years, 3 months ago (2016-08-30 02:02:01 UTC) #8
yosin_UTC9
Thanks for reviewing! https://codereview.chromium.org/2287283002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html File third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html (right): https://codereview.chromium.org/2287283002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html#newcode19 third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_separator.html:19: // A Testt for a bug ...
4 years, 3 months ago (2016-08-30 04:41:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287283002/20001
4 years, 3 months ago (2016-08-30 04:44:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 06:05:53 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:08:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07fbfac91e8b5f2160a041f16c9c57ccf1dcd613
Cr-Commit-Position: refs/heads/master@{#415198}

Powered by Google App Engine
This is Rietveld 408576698