Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
index 9c60f5cdc6ee003822d0e8c99edcc95e721faa3e..f532834f0b443040a63dc3c8eaf68f3bbb0d901b 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
@@ -233,7 +233,7 @@ void BluetoothRemoteGattCharacteristicWin::ReadRemoteCharacteristic(
}
void BluetoothRemoteGattCharacteristicWin::WriteRemoteCharacteristic(
- const std::vector<uint8_t>& new_value,
+ const std::vector<uint8_t>& value,
const base::Closure& callback,
const ErrorCallback& error_callback) {
DCHECK(ui_task_runner_->RunsTasksOnCurrentThread());
@@ -252,7 +252,7 @@ void BluetoothRemoteGattCharacteristicWin::WriteRemoteCharacteristic(
write_characteristic_value_callbacks_ =
std::make_pair(callback, error_callback);
task_manager_->PostWriteGattCharacteristicValue(
- parent_service_->GetServicePath(), characteristic_info_.get(), new_value,
+ parent_service_->GetServicePath(), characteristic_info_.get(), value,
base::Bind(&BluetoothRemoteGattCharacteristicWin::
OnWriteRemoteCharacteristicValueCallback,
weak_ptr_factory_.GetWeakPtr()));

Powered by Google App Engine
This is Rietveld 408576698