Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic.h

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_remote_gatt_characteristic_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_remote_gatt_characteristic.h
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic.h b/device/bluetooth/bluetooth_remote_gatt_characteristic.h
index f7035bab7e95d4bf2dde0efa84ebf79391ee3664..dcd5df1a7b743512ba489fc624fbae3a2ece51ad 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic.h
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic.h
@@ -123,13 +123,12 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristic
const ValueCallback& callback,
const ErrorCallback& error_callback) = 0;
- // Sends a write request to a remote characteristic, to modify the
- // characteristic's value with the new value |new_value|. |callback| is
- // called to signal success and |error_callback| for failures. This method
- // only applies to remote characteristics and will fail for those that are
- // locally hosted.
+ // Sends a write request to a remote characteristic with the value |value|.
+ // |callback| is called to signal success and |error_callback| for failures.
+ // This method only applies to remote characteristics and will fail for those
+ // that are locally hosted.
virtual void WriteRemoteCharacteristic(
- const std::vector<uint8_t>& new_value,
+ const std::vector<uint8_t>& value,
const base::Closure& callback,
const ErrorCallback& error_callback) = 0;
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_remote_gatt_characteristic_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698