Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_win.h

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_ 5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_
6 #define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_ 6 #define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <unordered_map> 9 #include <unordered_map>
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 bool IsNotifying() const override; 43 bool IsNotifying() const override;
44 std::vector<BluetoothRemoteGattDescriptor*> GetDescriptors() const override; 44 std::vector<BluetoothRemoteGattDescriptor*> GetDescriptors() const override;
45 BluetoothRemoteGattDescriptor* GetDescriptor( 45 BluetoothRemoteGattDescriptor* GetDescriptor(
46 const std::string& identifier) const override; 46 const std::string& identifier) const override;
47 void StartNotifySession(const NotifySessionCallback& callback, 47 void StartNotifySession(const NotifySessionCallback& callback,
48 const ErrorCallback& error_callback) override; 48 const ErrorCallback& error_callback) override;
49 void StopNotifySession(BluetoothGattNotifySession* session, 49 void StopNotifySession(BluetoothGattNotifySession* session,
50 const base::Closure& callback) override; 50 const base::Closure& callback) override;
51 void ReadRemoteCharacteristic(const ValueCallback& callback, 51 void ReadRemoteCharacteristic(const ValueCallback& callback,
52 const ErrorCallback& error_callback) override; 52 const ErrorCallback& error_callback) override;
53 void WriteRemoteCharacteristic(const std::vector<uint8_t>& new_value, 53 void WriteRemoteCharacteristic(const std::vector<uint8_t>& value,
54 const base::Closure& callback, 54 const base::Closure& callback,
55 const ErrorCallback& error_callback) override; 55 const ErrorCallback& error_callback) override;
56 56
57 // Update included descriptors. 57 // Update included descriptors.
58 void Update(); 58 void Update();
59 uint16_t GetAttributeHandle() const; 59 uint16_t GetAttributeHandle() const;
60 BluetoothRemoteGattServiceWin* GetWinService() { return parent_service_; } 60 BluetoothRemoteGattServiceWin* GetWinService() { return parent_service_; }
61 61
62 protected: 62 protected:
63 void SubscribeToNotifications(BluetoothRemoteGattDescriptor* ccc_descriptor, 63 void SubscribeToNotifications(BluetoothRemoteGattDescriptor* ccc_descriptor,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 // GATT event handle returned by GattEventRegistrationCallback. 135 // GATT event handle returned by GattEventRegistrationCallback.
136 PVOID gatt_event_handle_; 136 PVOID gatt_event_handle_;
137 137
138 base::WeakPtrFactory<BluetoothRemoteGattCharacteristicWin> weak_ptr_factory_; 138 base::WeakPtrFactory<BluetoothRemoteGattCharacteristicWin> weak_ptr_factory_;
139 DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicWin); 139 DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicWin);
140 }; 140 };
141 141
142 } // namespace device 142 } // namespace device
143 143
144 #endif // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_ 144 #endif // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698