Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/common/extensions/docs/server2/server_instance.py

Issue 228723005: Refactor APIDataSource to work with DataSourceRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tiny cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from api_categorizer import APICategorizer 5 from api_categorizer import APICategorizer
6 from api_data_source import APIDataSource 6 from api_data_source import APIDataSource
7 from api_list_data_source import APIListDataSource 7 from api_list_data_source import APIListDataSource
8 from api_models import APIModels 8 from api_models import APIModels
9 from availability_finder import AvailabilityFinder 9 from availability_finder import AvailabilityFinder
10 from compiled_file_system import CompiledFileSystem 10 from compiled_file_system import CompiledFileSystem
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 branch_utility, 86 branch_utility,
87 compiled_fs_factory, 87 compiled_fs_factory,
88 self.host_file_system_iterator, 88 self.host_file_system_iterator,
89 host_fs_at_trunk, 89 host_fs_at_trunk,
90 object_store_creator) 90 object_store_creator)
91 91
92 self.api_categorizer = APICategorizer( 92 self.api_categorizer = APICategorizer(
93 host_fs_at_trunk, 93 host_fs_at_trunk,
94 compiled_fs_factory) 94 compiled_fs_factory)
95 95
96 self.api_data_source_factory = APIDataSource.Factory(
97 self.compiled_fs_factory,
98 host_fs_at_trunk,
99 self.availability_finder,
100 self.api_models,
101 self.features_bundle,
102 self.object_store_creator)
103
104 self.ref_resolver = ReferenceResolver( 96 self.ref_resolver = ReferenceResolver(
105 self.api_models, 97 self.api_models,
106 self.object_store_creator.Create(ReferenceResolver)) 98 self.object_store_creator.Create(ReferenceResolver))
107 99
108 # Note: samples are super slow in the dev server because it doesn't support 100 # Note: samples are super slow in the dev server because it doesn't support
109 # async fetch, so disable them. 101 # async fetch, so disable them.
110 if IsDevServer(): 102 if IsDevServer():
111 extension_samples_fs = EmptyDirFileSystem() 103 extension_samples_fs = EmptyDirFileSystem()
112 app_samples_fs = EmptyDirFileSystem() 104 app_samples_fs = EmptyDirFileSystem()
113 else: 105 else:
114 extension_samples_fs = host_fs_at_trunk 106 extension_samples_fs = host_fs_at_trunk
115 # TODO(kalman): Re-enable the apps samples, see http://crbug.com/344097. 107 # TODO(kalman): Re-enable the apps samples, see http://crbug.com/344097.
116 app_samples_fs = EmptyDirFileSystem() 108 app_samples_fs = EmptyDirFileSystem()
117 #app_samples_fs = github_file_system_provider.Create( 109 #app_samples_fs = github_file_system_provider.Create(
118 # 'GoogleChrome', 'chrome-app-samples') 110 # 'GoogleChrome', 'chrome-app-samples')
119 self.samples_data_source_factory = SamplesDataSource.Factory( 111 self.samples_data_source_factory = SamplesDataSource.Factory(
120 extension_samples_fs, 112 extension_samples_fs,
121 app_samples_fs, 113 app_samples_fs,
122 CompiledFileSystem.Factory(object_store_creator), 114 CompiledFileSystem.Factory(object_store_creator),
123 self.ref_resolver, 115 self.ref_resolver,
124 base_path) 116 base_path)
125 117
126 self.api_data_source_factory.SetSamplesDataSourceFactory(
127 self.samples_data_source_factory)
128
129 self.content_providers = ContentProviders( 118 self.content_providers = ContentProviders(
130 object_store_creator, 119 object_store_creator,
131 self.compiled_fs_factory, 120 self.compiled_fs_factory,
132 host_fs_at_trunk, 121 host_fs_at_trunk,
133 self.github_file_system_provider, 122 self.github_file_system_provider,
134 self.gcs_file_system_provider) 123 self.gcs_file_system_provider)
135 124
136 # TODO(kalman): Move all the remaining DataSources into DataSourceRegistry, 125 # TODO(kalman): Move all the remaining DataSources into DataSourceRegistry,
137 # then factor out the DataSource creation into a factory method, so that 126 # then factor out the DataSource creation into a factory method, so that
138 # the entire ServerInstance doesn't need to be passed in here. 127 # the entire ServerInstance doesn't need to be passed in here.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 store_type=TestObjectStore) 163 store_type=TestObjectStore)
175 host_file_system_provider = HostFileSystemProvider.ForLocal( 164 host_file_system_provider = HostFileSystemProvider.ForLocal(
176 object_store_creator) 165 object_store_creator)
177 return ServerInstance( 166 return ServerInstance(
178 object_store_creator, 167 object_store_creator,
179 CompiledFileSystem.Factory(object_store_creator), 168 CompiledFileSystem.Factory(object_store_creator),
180 TestBranchUtility.CreateWithCannedData(), 169 TestBranchUtility.CreateWithCannedData(),
181 host_file_system_provider, 170 host_file_system_provider,
182 GithubFileSystemProvider.ForEmpty(), 171 GithubFileSystemProvider.ForEmpty(),
183 CloudStorageFileSystemProvider(object_store_creator)) 172 CloudStorageFileSystemProvider(object_store_creator))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698