Issue 228723003: Start on some unwritten SkRecord TODOs:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228723003: Start on some unwritten SkRecord TODOs: (Closed)

Created:
6 years, 8 months ago by mtklein_C

Modified:
6 years, 8 months ago

Reviewers:
mtklein, f(malita), fmalita_google_do_not_use

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@record-culling

Visibility:
Public.

Start on some unwritten SkRecord TODOs: - add SK_OVERRIDE for SkCanvas methods in SkRecorder - start on unit tests, here just for SkRecord itself BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14097

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -40 lines)			Patch
M	gyp/tests.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/record/SkRecorder.h	View	1 chunk	+68 lines, -40 lines	0 comments	Download
A	tests/RecordTest.cpp	View	1 chunk	+48 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

mtklein

This was bugging me while writing the CL to add push/pop culls. Hope you don't ...

6 years, 8 months ago (2014-04-08 15:19:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/228723003/20001

6 years, 8 months ago (2014-04-08 15:55:50 UTC) #5

Message was sent while issue was closed.

Change committed as 14097