Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: sdk/lib/convert/encoding.dart

Issue 22872012: Remove Encoding-enum from dart:io and add interface in dart:convert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix ddbg. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/convert/encoding.dart
diff --git a/sdk/lib/convert/encoding.dart b/sdk/lib/convert/encoding.dart
index 0f6126c25130921fea8c5d9e1a63eccf1b9023dc..6121815a474eaace7e9f4dede77972632801b66b 100644
--- a/sdk/lib/convert/encoding.dart
+++ b/sdk/lib/convert/encoding.dart
@@ -7,13 +7,22 @@ part of dart.convert;
/**
* Open-ended Encoding enum.
*/
-// TODO(floitsch): dart:io already has an Encoding class. If we can't
-// consolitate them, we need to remove `Encoding` here.
-abstract class _Encoding extends Codec<String, List<int>> {
- const _Encoding();
+abstract class Encoding extends Codec<String, List<int>> {
+ const Encoding();
- // TODO(floitsch): should we introduce a StringToByteEncoder and
- // a ByteToStringDecoder so that we have better typing?
-}
+ Future<String> decodeStream(Stream<List<int>> byteStream) {
+ return byteStream
+ .transform(decoder)
+ .fold(new StringBuffer(), (buffer, string) => buffer..write(string))
+ .then((buffer) => buffer.toString());
+ }
-// TODO(floitsch): add other encodings, like ASCII and ISO_8859_1.
+ /**
+ * Name of the encoding.
+ *
+ * If the encoding is standardized, this is the lower-case version of one of
+ * the IANA official names for the character set (see
+ * http://www.iana.org/assignments/character-sets/character-sets.xml)
+ */
+ String get name;
+}

Powered by Google App Engine
This is Rietveld 408576698