Remove Encoding-enum from dart:io and add interface in dart:convert.

Remove Encoding-enum from dart:io and add interface in dart:convert.

BUG= http://dartbug.com/6284
BUG= http://dartbug.com/7966
R=nweiz@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26632

[floitsch, 2013-08-23 15:05:35]

Breaking change.

- API has changed (should be covered by tests)
- Encodings are now strict, by default. ASCII, and UTF8 will *not* just replace
bad sequences with "?" or "�".

For the CCed (mostly Bill, Anders, Bob and Nathan) please verify especially the
strictness change. I had to adapt some tests, but I'm not sure if they were just
checking that nothing changed, or if they were actually relying on the old
behavior.

[hausner, 2013-08-23 15:35:52]

tools/ddbg.dart also needs to be updated.

[floitsch, 2013-08-23 15:56:28]

Updated ddbg.

[nweiz, 2013-08-23 19:40:00]

A couple nits, but otherwise the pkg and pub changes lgtm.

It's nice to see the encoding stuff get some love.

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
File pkg/barback/lib/src/asset.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
pkg/barback/lib/src/asset.dart:8: import 'dart:convert' show Encoding, UTF8;
Style nit: we usually don't import with "show". Same goes for other libraries
maintained by Bob and me.

https://codereview.chromium.org/22872012/diff/7001/pkg/http/lib/src/utils.dart
File pkg/http/lib/src/utils.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/http/lib/src/utils.dar...
pkg/http/lib/src/utils.dart:86: String decodeString(List<int> bytes, Encoding
encoding) {
This (and [encodeString] should just be replaced with manually calling
[encoding.decode].

https://codereview.chromium.org/22872012/diff/7001/pkg/http/test/request_test...
File pkg/http/test/request_test.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/http/test/request_test...
pkg/http/test/request_test.dart:66: expect(request.encoding.name,
equals(UTF8.name));
Do plain equality checks work on encoding objects now? If so, replace these with
"expect(request.encoding, equals(...))"

[floitsch, 2013-08-24 18:56:42]

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
File pkg/barback/lib/src/asset.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
pkg/barback/lib/src/asset.dart:8: import 'dart:convert' show Encoding, UTF8;
On 2013/08/23 19:40:00, nweiz wrote:
> Style nit: we usually don't import with "show". Same goes for other libraries
> maintained by Bob and me.

As long as this library still uses dart:utf this is not possible. There would be
a clash with Utf8Encoder (iirc).

https://codereview.chromium.org/22872012/diff/7001/pkg/http/test/request_test...
File pkg/http/test/request_test.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/http/test/request_test...
pkg/http/test/request_test.dart:66: expect(request.encoding.name,
equals(UTF8.name));
On 2013/08/23 19:40:00, nweiz wrote:
> Do plain equality checks work on encoding objects now? If so, replace these
with
> "expect(request.encoding, equals(...))"

Encoding is an interface. There is no guarantee that you get the same instance
(although it is very likely).

I don't see how this wasn't working before (the encoding enum should have had
guarantees that it always returned the same object), so I'm leaving it as is.

[Søren Gjesse, 2013-08-26 08:03:15]

LGTM! Nice change!

https://codereview.chromium.org/22872012/diff/7001/sdk/lib/io/string_transfor...
File sdk/lib/io/string_transformer.dart (right):

https://codereview.chromium.org/22872012/diff/7001/sdk/lib/io/string_transfor...
sdk/lib/io/string_transformer.dart:49: Encoding encodingFromName(String name) {
Should this move to dart:convert as well? With the option of registration of
additional converters?

[floitsch, 2013-08-26 09:33:39]

https://codereview.chromium.org/22872012/diff/7001/pkg/http/lib/src/utils.dart
File pkg/http/lib/src/utils.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/http/lib/src/utils.dar...
pkg/http/lib/src/utils.dart:86: String decodeString(List<int> bytes, Encoding
encoding) {
On 2013/08/23 19:40:00, nweiz wrote:
> This (and [encodeString] should just be replaced with manually calling
> [encoding.decode].

Done.

https://codereview.chromium.org/22872012/diff/7001/sdk/lib/io/string_transfor...
File sdk/lib/io/string_transformer.dart (right):

https://codereview.chromium.org/22872012/diff/7001/sdk/lib/io/string_transfor...
sdk/lib/io/string_transformer.dart:49: Encoding encodingFromName(String name) {
On 2013/08/26 08:03:15, Søren Gjesse wrote:
> Should this move to dart:convert as well? With the option of registration of
> additional converters?

Moved to Encoding.getByName.

No option to register additional converters yet, but we will think about it.
Filed issue 12741 to track this.

[floitsch, 2013-08-26 10:38:19]

Committed patchset #7 manually as r26632 (presubmit successful).

[nweiz, 2013-08-26 17:48:43]

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
File pkg/barback/lib/src/asset.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
pkg/barback/lib/src/asset.dart:8: import 'dart:convert' show Encoding, UTF8;
On 2013/08/24 18:56:42, floitsch wrote:
> On 2013/08/23 19:40:00, nweiz wrote:
> > Style nit: we usually don't import with "show". Same goes for other
libraries
> > maintained by Bob and me.
> 
> As long as this library still uses dart:utf this is not possible. There would
be
> a clash with Utf8Encoder (iirc).

Why is this library still using dart:utf? Shouldn't it be switched over entirely
to dart:convert?

[floitsch, 2013-08-26 17:58:42]

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
File pkg/barback/lib/src/asset.dart (right):

https://codereview.chromium.org/22872012/diff/7001/pkg/barback/lib/src/asset....
pkg/barback/lib/src/asset.dart:8: import 'dart:convert' show Encoding, UTF8;
On 2013/08/26 17:48:43, nweiz wrote:
> On 2013/08/24 18:56:42, floitsch wrote:
> > On 2013/08/23 19:40:00, nweiz wrote:
> > > Style nit: we usually don't import with "show". Same goes for other
> libraries
> > > maintained by Bob and me.
> > 
> > As long as this library still uses dart:utf this is not possible. There
would
> be
> > a clash with Utf8Encoder (iirc).
> 
> Why is this library still using dart:utf? Shouldn't it be switched over
entirely
> to dart:convert?

Working on it in a separate CL. There this line is already without 'show'.