Start using OAuth2 for sync cacheinvalidation.

Start using OAuth2 for sync cacheinvalidation.

Currently our cacheinvalidation implementation still uses clientlogin.
This changes our implementation to instead use OAuth2.

This requires the roll to r313 of the cacheinvalidation library.

BUG=264503
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222262

[nyquist, 2013-08-12 16:33:45]

ghc: PTAL

[pavely, 2013-08-12 18:06:42]

On 2013/08/12 16:33:45, nyquist wrote:
> ghc: PTAL

Tommy,

On desktop invalidation service to connect to XMPP server needed googletalk
scope, chromesync scope didn't work with it. It might be the same on Android,
could you check?

[nyquist, 2013-08-12 18:11:16]

From before at least, we used the 'chromiumsync' scope, and not Google Talk. The
XMPP channel is handled by the Android system (GCM for Android), so I believe we
do not need that.

Chrome for Android does not have its own XMPP channel.

[ghc, 2013-08-12 18:25:48]

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
File sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java
(right):

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java:440:
return "oauth2:" + SyncStatusHelper.CHROME_SYNC_OAUTH2_SCOPE;
I don't see this constant defined in head (or in this CL). Am I looking in the
right place?

http://src.chromium.org/viewvc/chrome/trunk/src/sync/android/java/src/org/chr...

[nyquist, 2013-08-12 18:30:56]

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
File sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java
(right):

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java:440:
return "oauth2:" + SyncStatusHelper.CHROME_SYNC_OAUTH2_SCOPE;
On 2013/08/12 18:25:48, ghc wrote:
> I don't see this constant defined in head (or in this CL). Am I looking in the
> right place?
> 
>
http://src.chromium.org/viewvc/chrome/trunk/src/sync/android/java/src/org/chr...

My bad for not clarifying. This CL depends on
https://codereview.chromium.org/22868002/

[ghc, 2013-08-12 18:50:27]

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
File sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java
(right):

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java:440:
return "oauth2:" + SyncStatusHelper.CHROME_SYNC_OAUTH2_SCOPE;
On 2013/08/12 18:30:57, nyquist wrote:
> On 2013/08/12 18:25:48, ghc wrote:
> > I don't see this constant defined in head (or in this CL). Am I looking in
the
> > right place?
> > 
> >
>
http://src.chromium.org/viewvc/chrome/trunk/src/sync/android/java/src/org/chr...
> 
> My bad for not clarifying. This CL depends on
> https://codereview.chromium.org/22868002/

Thanks. Does the scope actually need to flow back in the request? (I thought the
OAuth token was self-contained.)

[pavely, 2013-08-12 18:58:39]

On 2013/08/12 18:11:16, nyquist wrote:
> From before at least, we used the 'chromiumsync' scope, and not Google Talk.
The
> XMPP channel is handled by the Android system (GCM for Android), so I believe
we
> do not need that.
> 
> Chrome for Android does not have its own XMPP channel.

It was the same story for desktop: 'chromiumsync' worked for xmpp but when i
tried to pass oauth2 chromesync token it didn't work.
Anyway, just try it once, either it will work or won't.

[nyquist, 2013-09-05 23:15:35]

PTAL

Roll to cacheinvalidation r313 is here:
https://codereview.chromium.org/23603003/

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
File sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java
(right):

https://codereview.chromium.org/22872002/diff/1/sync/android/java/src/org/chr...
sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java:440:
return "oauth2:" + SyncStatusHelper.CHROME_SYNC_OAUTH2_SCOPE;
Yeah, the token is self-contained, but new cacheinvalidation library that
supports OAuth2 needs to know whether it is a clientlogin or OAuth2 scope.

See https://code.google.com/p/google-cache-invalidation-api/source/detail?r=313
for details, which is rolled in here: https://codereview.chromium.org/23603003/

On 2013/08/12 18:50:27, ghc wrote:
> On 2013/08/12 18:30:57, nyquist wrote:
> > On 2013/08/12 18:25:48, ghc wrote:
> > > I don't see this constant defined in head (or in this CL). Am I looking in
> the
> > > right place?
> > > 
> > >
> >
>
http://src.chromium.org/viewvc/chrome/trunk/src/sync/android/java/src/org/chr...
> > 
> > My bad for not clarifying. This CL depends on
> > https://codereview.chromium.org/22868002/
> 
> Thanks. Does the scope actually need to flow back in the request? (I thought
the
> OAuth token was self-contained.)
>

[ghc, 2013-09-06 00:50:41]

LGTM but I don't know this code very well. Have you tested that this works with
the new client library and changes to the server?

[nyquist, 2013-09-09 23:53:13]

Yeah, I've tried it locally.

[nyquist, 2013-09-10 00:07:11]

Retried after the roll of cacheinvalidation and rebase, and still works. Also
verified manually that it goes through the parts of the client library code that
we want it to go through.

[commit-bot: I haz the power, 2013-09-10 00:11:56]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[shashi, 2013-09-10 00:57:05]

lgtm.
I guess SyncStatusHelper.AUTH_TOKEN_TYPE_SYNC can now be removed after tests are
migrated to use the new tokens.

Also verify by running downstream and upstream sync tests.

[commit-bot: I haz the power, 2013-09-10 01:03:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 01:41:44]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 02:06:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 02:17:11]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 02:24:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 02:34:16]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 03:43:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 03:51:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 05:59:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 08:03:44]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-10 08:08:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 10:04:20]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-10 15:23:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22872002/11001

[commit-bot: I haz the power, 2013-09-10 16:01:23]

Change committed as 222262