src/full-codegen/full-codegen.cc - Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: restore undefined handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 657b97934b514e3d7f7faff2270e5e8f53dd1209..e4c69e74f58dd91cb8512682f74a32b7cc801dfa 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -839,8 +839,8 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) {

DCHECK(!context()->IsEffect());

DCHECK(!context()->IsTest());

- if (proxy != NULL && (proxy->var()->IsUnallocatedOrGlobalSlot() ||

- proxy->var()->IsLookupSlot())) {

+ if (proxy != NULL &&

+ (proxy->var()->IsUnallocated() || proxy->var()->IsLookupSlot())) {

EmitVariableLoad(proxy, INSIDE_TYPEOF);

PrepareForBailout(proxy, BailoutState::TOS_REGISTER);

} else {

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »