Replace CollectVariables with locals(), update callsites to walk locals instead

src/debug/liveedit.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/liveedit.h"
 
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compilation-cache.h"
 #include "src/compiler.h"
@@ skipping 1882 matching lines @@
 Handle<Object> LiveEditFunctionTracker::SerializeFunctionScope(Scope* scope) {
   Handle<JSArray> scope_info_list = isolate_->factory()->NewJSArray(10);
   int scope_info_length = 0;
 
   // Saves some description of scope. It stores name and indexes of
   // variables in the whole scope chain. Null-named slots delimit
   // scopes of this chain.
   Scope* current_scope = scope;
   while (current_scope != NULL) {
     HandleScope handle_scope(isolate_);
-    ZoneList<Variable*> stack_list(current_scope->StackLocalCount(), zone_);
-    ZoneList<Variable*> context_list(current_scope->ContextLocalCount(), zone_);
-    ZoneList<Variable*> globals_list(current_scope->ContextGlobalCount(),
-                                     zone_);
-    current_scope->CollectVariables(&stack_list, &context_list, &globals_list);
-    for (int i = 0; i < context_list.length(); i++) {
-      int context_index = context_list[i]->index() - Context::MIN_CONTEXT_SLOTS;
+    ZoneList<Variable*>* locals = current_scope->locals();
+    for (int i = 0; i < locals->length(); i++) {
+      Variable* var = locals->at(i);
+      if (!var->IsContextSlot()) continue;
+      int context_index = var->index() - Context::MIN_CONTEXT_SLOTS;
       int location = scope_info_length + context_index * 2;
-      SetElementSloppy(scope_info_list, location, context_list[i]->name());
-      SetElementSloppy(
-          scope_info_list, location + 1,
-          handle(Smi::FromInt(context_list[i]->index()), isolate_));
+      SetElementSloppy(scope_info_list, location, var->name());
+      SetElementSloppy(scope_info_list, location + 1,
+                       handle(Smi::FromInt(var->index()), isolate_));
     }
-    scope_info_length += context_list.length() * 2;
+    scope_info_length += current_scope->ContextLocalCount() * 2;
     SetElementSloppy(scope_info_list, scope_info_length,
-                     Handle<Object>(isolate_->heap()->null_value(), isolate_));
+                     isolate_->factory()->null_value());
     scope_info_length++;
 
     current_scope = current_scope->outer_scope();
   }
 
   return scope_info_list;
 }
 
 }  // namespace internal
 }  // namespace v8