Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2287143003: Disable PasswordManagerBrowserTestBase.InternalsPage on Mac (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PasswordManagerBrowserTestBase.InternalsPage on Mac The test flakes on Mac. BUG=640737 TBR=vasilii@chromium.org Committed: https://crrev.com/2683579867440a6ead8e06329f00bd7d0b3a1ce2 Cr-Commit-Position: refs/heads/master@{#414996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vabr (Chromium)
Hi Vasilii, I am TBRing you for disabling a test. I intend to also fix ...
4 years, 3 months ago (2016-08-29 09:58:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287143003/1
4 years, 3 months ago (2016-08-29 09:58:35 UTC) #3
vasilii
lgtm
4 years, 3 months ago (2016-08-29 10:40:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 11:15:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2683579867440a6ead8e06329f00bd7d0b3a1ce2 Cr-Commit-Position: refs/heads/master@{#414996}
4 years, 3 months ago (2016-08-29 11:17:13 UTC) #7
vabr (Chromium)
4 years, 3 months ago (2016-08-30 08:51:44 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2292893002/ by vabr@chromium.org.

The reason for reverting is: As leonhsl@ noted on
https://codereview.chromium.org/2270333002/, the test failures only happened
when the Mojo change https://codereview.chromium.org/2216463002 was on the
trunk. Looking at the list of flakes [1], the revision numbers speak clearly:
413708 = Mojo change went in
413716 = first flake recorded
413923 = last flake recorded
413934 = Mojo change reverted

Therefore the revert is not needed, the Mojo change needs to be fixed before
relanding.

[1]
https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9....

Powered by Google App Engine
This is Rietveld 408576698