Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 22871008: Compensate for the lack of code motion in licm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/licm_test.dart » ('j') | tests/compiler/dart2js/licm_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 26189)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -1040,7 +1040,10 @@
HBasicBlock preheader = loopHeader.predecessors[0];
int dependsFlags = SideEffects.computeDependsOnFlags(changesFlags);
HInstruction instruction = block.first;
- bool firstInstructionInLoop = block == loopHeader;
+ bool firstInstructionInLoop = block == loopHeader
+ // Compensate for lack of code motion.
+ || (blockChangesFlags[loopHeader.id] == 0
+ && loopHeader.successors[0] == block);
while (instruction != null) {
HInstruction next = instruction.next;
if (instruction.useGvn()
« no previous file with comments | « no previous file | tests/compiler/dart2js/licm_test.dart » ('j') | tests/compiler/dart2js/licm_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698