Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 22871007: Revert 217768 "Adding key press detection in the browser process." (Closed)

Created:
7 years, 4 months ago by phoglund_chromium
Modified:
7 years, 4 months ago
Reviewers:
phoglund1, jiayl
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217768 "Adding key press detection in the browser process." > Adding key press detection in the browser process. > It works like this on the browser side: > A new object KeyPressMonitor is created on BrowserMainLoop and passed to AudioInputRendererHost to pass to AudioInputController. > AudioInputController::DoRecord calls KeyPressMonitor::AddKeyPressListener --> KeyPressMonitor listens to system key events through UserInputMonitor(only implemented on Linux) --> AudioInputController::OnKeyPressed is called and sets key_pressed_ --> When AudioInputController::OnData called, it writes key_pressed_ to shared memory along with the audio data buffer. > On the renderer side a new param "key_pressed" is added through the code path of passing the flag to the webrtc voice engine. > This CL includes all these changes except the implementation of UserInputMonitor for Windows and Mac. The impl of UserInputMonitor is mostly copied from remoting/host/local_input_monitor_linux.cc > > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/21183002 TBR=jiayl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -931 lines) Patch
M trunk/src/content/browser/browser_main_loop.h View 3 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/content/browser/browser_main_loop.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.h View 3 chunks +4 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.cc View 2 chunks +13 lines, -17 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_sync_writer.h View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_input_sync_writer.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
MM trunk/src/content/browser/speech/speech_recognizer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/webaudio_capturer_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer_sink_owner.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer_sink_owner.cc View 1 chunk +5 lines, -11 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_device_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_device_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_device_unittest.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_renderer.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_track.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_track.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc View 10 chunks +43 lines, -89 lines 0 comments Download
M trunk/src/content/test/webrtc_audio_device_test.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M trunk/src/media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/media/audio/audio_input_controller.h View 9 chunks +11 lines, -35 lines 0 comments Download
M trunk/src/media/audio/audio_input_controller.cc View 10 chunks +16 lines, -37 lines 0 comments Download
M trunk/src/media/audio/audio_input_controller_unittest.cc View 5 chunks +14 lines, -36 lines 0 comments Download
M trunk/src/media/audio/audio_input_device.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/media/audio/audio_parameters.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/media/audio/test_audio_input_controller_factory.h View 3 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/media/audio/test_audio_input_controller_factory.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/media/base/audio_capturer_source.h View 1 chunk +1 line, -2 lines 0 comments Download
D trunk/src/media/base/user_input_monitor.h View 1 chunk +0 lines, -99 lines 0 comments Download
D trunk/src/media/base/user_input_monitor.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D trunk/src/media/base/user_input_monitor_linux.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D trunk/src/media/base/user_input_monitor_mac.mm View 1 chunk +0 lines, -16 lines 0 comments Download
D trunk/src/media/base/user_input_monitor_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/media/media.gyp View 6 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
phoglund_chromium
7 years, 4 months ago (2013-08-15 11:08:51 UTC) #1
phoglund_chromium
Committed patchset #1 manually as r217774.
7 years, 4 months ago (2013-08-15 11:11:38 UTC) #2
phoglund1
7 years, 4 months ago (2013-08-15 11:13:36 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698