Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 22871006: Implement unregisterProtocolHandler() function on CUSTOM_SCHEME_HANDLER (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement unregisterProtocolHandler() function As a step to support CUSTOM_SCHEME_HANDLER, this cl implements unregisterProtocolHandler() first. The isProtocolRegistered() is not implemented yet. It will be supported after talking with W3C group. This patch introduces a customSchemeHandler runtime flag to support this feature as an experimental feature. Additionally, this cl changes SYNTAX_ERR with SyntaxError in unregister-protocol-handler.html. BUG= N/A

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Patch based on issue 22855008 #

Patch Set 4 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M LayoutTests/fast/dom/unregister-protocol-handler.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 3 1 chunk +4 lines, -0 lines 2 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 3 1 chunk +3 lines, -0 lines 2 comments Download
M public/web/WebViewClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
Hi Abarth, As you can see, it looks there was no objection to implement *unregisterProtocolHandler()* ...
7 years, 4 months ago (2013-08-15 15:41:00 UTC) #1
abarth-chromium
https://codereview.chromium.org/22871006/diff/2001/Source/web/ChromeClientImpl.h File Source/web/ChromeClientImpl.h (right): https://codereview.chromium.org/22871006/diff/2001/Source/web/ChromeClientImpl.h#newcode211 Source/web/ChromeClientImpl.h:211: #if ENABLE(CUSTOM_SCHEME_HANDLER) We no longer use #ifdefs to scope ...
7 years, 4 months ago (2013-08-15 20:05:49 UTC) #2
gyuyoung-inactive
> We no longer use #ifdefs to scope in-progress feature development. Instead, we > use ...
7 years, 4 months ago (2013-08-16 07:07:13 UTC) #3
gyuyoung-inactive
> https://codereview.chromium.org/22871006/diff/2001/Source/web/ChromeClientImpl.h > File Source/web/ChromeClientImpl.h (right): > > https://codereview.chromium.org/22871006/diff/2001/Source/web/ChromeClientImpl.h#newcode211 > Source/web/ChromeClientImpl.h:211: #if ENABLE(CUSTOM_SCHEME_HANDLER) > On ...
7 years, 4 months ago (2013-08-16 07:07:59 UTC) #4
gyuyoung-inactive
Hi Abarth, Could you take a look 22855008 first ? https://codereview.chromium.org/22855008/ In my humble opinion, ...
7 years, 4 months ago (2013-08-18 05:12:18 UTC) #5
gyuyoung-inactive
Patch is updated regardless of issue 22855008.
7 years, 4 months ago (2013-08-21 04:05:43 UTC) #6
gyuyoung-inactive
On 2013/08/21 04:05:43, gyuyoung wrote: > Patch is updated regardless of issue 22855008. Abarth, could ...
7 years, 4 months ago (2013-08-21 06:41:18 UTC) #7
abarth-chromium
https://codereview.chromium.org/22871006/diff/16001/Source/web/ChromeClientImpl.h File Source/web/ChromeClientImpl.h (right): https://codereview.chromium.org/22871006/diff/16001/Source/web/ChromeClientImpl.h#newcode211 Source/web/ChromeClientImpl.h:211: #if ENABLE(CUSTOM_SCHEME_HANDLER) Please do not add any more ENABLE ...
7 years, 4 months ago (2013-08-21 17:10:19 UTC) #8
gyuyoung-inactive
7 years, 4 months ago (2013-08-22 01:12:38 UTC) #9
https://codereview.chromium.org/22871006/diff/16001/Source/web/ChromeClientIm...
File Source/web/ChromeClientImpl.h (right):

https://codereview.chromium.org/22871006/diff/16001/Source/web/ChromeClientIm...
Source/web/ChromeClientImpl.h:211: #if ENABLE(CUSTOM_SCHEME_HANDLER)
On 2013/08/21 17:10:19, abarth wrote:

> The way I would approach this change is to first remove
> ENABLE(CUSTOM_SCHEME_HANDLER) entirely in favor of a runtime flag.  Then I
would
> add the new functionality.

Abarth, I upload a patch to remove all ENABLE(CUSTOM_SCHEME_HANDLER) at
https://codereview.chromium.org/22859043/. I will update this patch after
landing it. Thanks.

https://codereview.chromium.org/22871006/diff/16001/public/web/WebRuntimeFeat...
File public/web/WebRuntimeFeatures.h (right):

https://codereview.chromium.org/22871006/diff/16001/public/web/WebRuntimeFeat...
public/web/WebRuntimeFeatures.h:144: WEBKIT_EXPORT static bool
isCustomSchemeHandlerEnabled();
On 2013/08/21 17:10:19, abarth wrote:
> There is no need to expose this API separately.  It's covered by the omnibus
> "experimental" API.

I wonder if the "experimental" API is generated automatically, right ? Or,
should I do something for it ?

Powered by Google App Engine
This is Rietveld 408576698