Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: net/quic/chromium/quic_stream_factory.cc

Issue 2287073002: Ignore errors on SetDoNotFragment on platforms where it is not implemented. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_stream_factory.cc
diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc
index 2e7f2b67f77ed9bf075ae0616a1e758a26bcd95a..80e95cd19f3e94ce9efe7b257ba659abe4c50b04 100644
--- a/net/quic/chromium/quic_stream_factory.cc
+++ b/net/quic/chromium/quic_stream_factory.cc
@@ -1706,7 +1706,8 @@ int QuicStreamFactory::ConfigureSocket(DatagramClientSocket* socket,
}
rv = socket->SetDoNotFragment();
- if (rv != OK) {
+ // SetDoNotFragment is not implemented on all platforms, so ignore errors.
+ if (rv != OK && rv != ERR_NOT_IMPLEMENTED) {
Ryan Hamilton 2016/08/27 21:55:56 Alternatively, we could ignore ALL errors since it
HistogramCreateSessionFailure(CREATION_ERROR_SETTING_NO_NOT_FRAGMENT);
mef 2016/08/29 19:27:14 nit: This should probably be CREATION_ERROR_SETTIN
Ryan Hamilton 2016/08/29 19:42:48 Good point. Will do so in a followup since this ha
Ryan Hamilton 2016/08/29 23:31:15 Ok, I gave up on the CQ and landed this manually,
return rv;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698