Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chromeos/dbus/fake_session_manager_client.cc

Issue 228703004: Start session fail causes restart chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed more browser tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_session_manager_client.cc
diff --git a/chromeos/dbus/fake_session_manager_client.cc b/chromeos/dbus/fake_session_manager_client.cc
index 306ade59bb9f3b10c736b9f0a491593205535d31..22db7fe8baf561d761ef5367019b81142a9a577f 100644
--- a/chromeos/dbus/fake_session_manager_client.cc
+++ b/chromeos/dbus/fake_session_manager_client.cc
@@ -46,11 +46,18 @@ void FakeSessionManagerClient::RestartJob(int pid,
const std::string& command_line) {
}
-void FakeSessionManagerClient::StartSession(const std::string& user_email) {
+void FakeSessionManagerClient::StartSession(
+ const std::string& user_email,
+ const StartSessionCallback& callback) {
DCHECK_EQ(0UL, user_sessions_.count(user_email));
std::string user_id_hash =
CryptohomeClient::GetStubSanitizedUsername(user_email);
user_sessions_[user_email] = user_id_hash;
+ base::MessageLoop* loop = base::MessageLoop::current();
+ if (loop)
Nikita (slow) 2014/04/18 05:22:59 nit: Add comment why such check is needed.
Roman Sorokin (ftl) 2014/04/22 08:28:47 Done.
+ loop->PostTask(FROM_HERE, base::Bind(callback, true));
+ else
+ callback.Run(true);
}
void FakeSessionManagerClient::StopSession() {

Powered by Google App Engine
This is Rietveld 408576698