Start session fail causes restart chrome

chromeos/dbus/fake_session_manager_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/fake_session_manager_client.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
@@ skipping 28 matching lines @@
   return observers_.HasObserver(observer);
 }
 
 void FakeSessionManagerClient::EmitLoginPromptVisible() {
 }
 
 void FakeSessionManagerClient::RestartJob(int pid,
                                           const std::string& command_line) {
 }
 
-void FakeSessionManagerClient::StartSession(const std::string& user_email) {
+void FakeSessionManagerClient::StartSession(
+    const std::string& user_email,
+    const StartSessionCallback& callback) {
   DCHECK_EQ(0UL, user_sessions_.count(user_email));
   std::string user_id_hash =
       CryptohomeClient::GetStubSanitizedUsername(user_email);
   user_sessions_[user_email] = user_id_hash;
+  base::MessageLoop* loop = base::MessageLoop::current();
+  // We need to check cause in some testing environments there is no loop and
+  // MessageLoop::current() returns NULL.

[oshima, 2014/04/22 10:03:32]

Isn't it possible to create a message lop in such test instead of adding a code
for test?

[Roman Sorokin (ftl), 2014/04/24 11:49:25]

Yes, it is. In this browser test we need to start sessions before browser start.
So I would create message loop for processing callbacks from session manager

+  if (loop)
+    loop->PostTask(FROM_HERE, base::Bind(callback, true));
+  else
+    callback.Run(true);
 }
 
 void FakeSessionManagerClient::StopSession() {
 }
 
 void FakeSessionManagerClient::StartDeviceWipe() {
   start_device_wipe_call_count_++;
 }
 
 void FakeSessionManagerClient::RequestLockScreen() {
@@ skipping 102 matching lines @@
     const std::string& account_id,
     const std::string& policy_blob) {
   device_local_account_policy_[account_id] = policy_blob;
 }
 
 void FakeSessionManagerClient::OnPropertyChangeComplete(bool success) {
   FOR_EACH_OBSERVER(Observer, observers_, PropertyChangeComplete(success));
 }
 
 }  // namespace chromeos