Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228703003: Remove duplicate AppendSwitch in AccountsOptionsTest. (Closed)

Created:
6 years, 8 months ago by Thiemo Nagel
Modified:
6 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove duplicate AppendSwitch in AccountsOptionsTest. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Hi Nikita, please take a look at this minimal fix: The line command_line->AppendSwitch(::switches::kMultiProfiles); can be ...
6 years, 8 months ago (2014-04-10 14:01:11 UTC) #1
Nikita (slow)
lgtm
6 years, 8 months ago (2014-04-10 15:34:20 UTC) #2
Thiemo Nagel
On 2014/04/10 15:34:20, Nikita Kostylev wrote: > lgtm Thank you!
6 years, 8 months ago (2014-04-10 16:07:33 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-10 16:07:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/228703003/1
6 years, 8 months ago (2014-04-10 16:07:55 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:09:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 263042

Powered by Google App Engine
This is Rietveld 408576698