Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2287003002: Add support for glDrawRangeElements (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add to test interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +24 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
This lets the driver know what range of the vertex buffer a draw uses.
4 years, 3 months ago (2016-08-29 15:20:52 UTC) #3
egdaniel
lgtm
4 years, 3 months ago (2016-08-29 15:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287003002/20001
4 years, 3 months ago (2016-08-29 15:50:15 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 16:18:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fc9527a0dfab9b4e2f6c1b8a7ff23a61a5e6b31f

Powered by Google App Engine
This is Rietveld 408576698