ui/gfx/android/java_bitmap.h - Issue 22870016: Update the nine patch layer to use UI resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/android/java_bitmap.h

Issue 22870016: Update the nine patch layer to use UI resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comments to reflect changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_GFX_ANDROID_JAVA_BITMAP_H_	5 #ifndef UI_GFX_ANDROID_JAVA_BITMAP_H_

6 #define UI_GFX_ANDROID_JAVA_BITMAP_H_	6 #define UI_GFX_ANDROID_JAVA_BITMAP_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 #include "base/android/scoped_java_ref.h"	10 #include "base/android/scoped_java_ref.h"

(...skipping 26 matching lines...) Expand all Loading...
37 gfx::Size size_;	37 gfx::Size size_;

38 int format_;	38 int format_;

39 uint32_t stride_;	39 uint32_t stride_;

40	40

41 DISALLOW_COPY_AND_ASSIGN(JavaBitmap);	41 DISALLOW_COPY_AND_ASSIGN(JavaBitmap);

42 };	42 };

43	43

44 UI_EXPORT base::android::ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(	44 UI_EXPORT base::android::ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(

45 const SkBitmap* skbitmap);	45 const SkBitmap* skbitmap);

46	46

	47 UI_EXPORT SkBitmap CreateSkBitmapFromJavaBitmap(JavaBitmap& jbitmap);
	Yaron 2013/09/10 00:28:39 Why is this exported/declared here? I may be missi Why is this exported/declared here? I may be missing where it's being called from. powei 2013/09/10 00:42:44 Called in java_bitmap.cc and also in LayerDecorati Show quoted text On 2013/09/10 00:28:39, Yaron wrote: > Why is this exported/declared here? I may be missing where it's being called > from. Called in java_bitmap.cc and also in LayerDecorationCache on the android side. Yaron 2013/09/10 01:23:03 Missed the LayerDecorationCache one. Thanks. Show quoted text On 2013/09/10 00:42:44, powei wrote: > On 2013/09/10 00:28:39, Yaron wrote: > > Why is this exported/declared here? I may be missing where it's being called > > from. > > Called in java_bitmap.cc and also in LayerDecorationCache on the android side. Missed the LayerDecorationCache one. Thanks.
	48

47 // If the resource loads successfully, it will be resized to \|size\|.	49 // If the resource loads successfully, it will be resized to \|size\|.

48 // Note: If the source resource is smaller than \|size\|, quality may suffer.	50 // Note: If the source resource is smaller than \|size\|, quality may suffer.

49 UI_EXPORT SkBitmap CreateSkBitmapFromResource(const char* name, gfx::Size size);	51 UI_EXPORT SkBitmap CreateSkBitmapFromResource(const char* name, gfx::Size size);

50	52

51 } // namespace gfx	53 } // namespace gfx

52	54

53 #endif // UI_GFX_ANDROID_JAVA_BITMAP_H_	55 #endif // UI_GFX_ANDROID_JAVA_BITMAP_H_

OLD	NEW

« cc/resources/ui_resource_bitmap.cc ('K') | « content/public/browser/android/compositor_client.h ('k') | ui/gfx/android/java_bitmap.cc » ('j') | ui/gfx/android/java_bitmap.cc » ('J')