Update the nine patch layer to use UI resources

cc/resources/ui_resource_bitmap.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/ui_resource_bitmap.h"
 
+#include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
+#include "third_party/skia/include/core/SkBitmap.h"
 
 namespace cc {
 
-scoped_refptr<UIResourceBitmap>
-UIResourceBitmap::Create(uint8_t* pixels,
-                         UIResourceFormat format,
-                         UIResourceWrapMode wrap_mode,
-                         gfx::Size size) {
-  scoped_refptr<UIResourceBitmap> ret = new UIResourceBitmap();
-  ret->pixels_ = scoped_ptr<uint8_t[]>(pixels);
-  ret->format_ = format;
-  ret->wrap_mode_ = wrap_mode;
-  ret->size_ = size;
-
-  return ret;
+uint8_t* UIResourceBitmap::GetPixels() const {
+  if (!pixel_ref_)
+    return NULL;
+  return static_cast<uint8_t*>(pixel_ref_->pixels());
 }
 
-UIResourceBitmap::UIResourceBitmap() {}
+void UIResourceBitmap::Create(const skia::RefPtr<SkPixelRef>& pixel_ref,
+                              UIResourceFormat format,
+                              UIResourceWrapMode wrap_mode,
+                              gfx::Size size) {
+  DCHECK(size.width() && size.height());
+  DCHECK(pixel_ref && pixel_ref->isImmutable());

[aelias_OOO_until_Jul13, 2013/09/09 23:11:11]

Please separate these into 4 DCHECKs.  In general, && in DCHECKs is best avoided
because it makes them harder to interpret when they trigger.

[powei, 2013/09/10 00:42:44]

Done.

+  format_ = format;
+  wrap_mode_ = wrap_mode;
+  size_ = size;
+  pixel_ref_ = pixel_ref;
+}
+
+UIResourceBitmap::UIResourceBitmap(const SkBitmap& skbitmap,
+                                   UIResourceWrapMode wrap_mode) {
+  DCHECK_EQ(skbitmap.config(), SkBitmap::kARGB_8888_Config);

[aelias_OOO_until_Jul13, 2013/09/09 23:11:11]

Please also DCHECK(skbitmap.width(), skbitmap.rowBytesAsPixels());
I made this request in #36; not a big deal but please come up with a systematic
workflow for not skipping over code review comments in the future.  (I use the
trick that if there's an odd number of comments, it usually means there's one I
didn't reply "Done" to.)

[powei, 2013/09/10 00:42:44]

Yes.  This was a problem.  I will try to be more careful.

+  DCHECK(skbitmap.isImmutable());
+  skia::RefPtr<SkPixelRef> pixel_ref = skia::SharePtr(skbitmap.pixelRef());
+  Create(pixel_ref,
+         UIResourceBitmap::RGBA8,
+         wrap_mode,
+         gfx::Size(skbitmap.width(), skbitmap.height()));
+}
+
 UIResourceBitmap::~UIResourceBitmap() {}
 
 }  // namespace cc