Update the nine patch layer to use UI resources

ui/gfx/android/java_bitmap.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/android/java_bitmap.h"
 
 #include <android/bitmap.h>
 
 #include "base/logging.h"
 #include "jni/BitmapHelper_jni.h"
@@ skipping 53 matching lines @@
 static ScopedJavaLocalRef<jobject> CreateJavaBitmapFromResource(
     const char* name, gfx::Size requested_size) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jstring> jname(env, env->NewStringUTF(name));
   return ui::Java_BitmapHelper_decodeDrawableResource(env,
                                                       jname.obj(),
                                                       requested_size.width(),
                                                       requested_size.height());
 }
 
-static SkBitmap ConvertToSkBitmap(ScopedJavaLocalRef<jobject> jbitmap) {
-  if (jbitmap.is_null())
-    return SkBitmap();
+SkBitmap CreateSkBitmapFromJavaBitmap(JavaBitmap& jbitmap) {
+  DCHECK_EQ(jbitmap.format(), ANDROID_BITMAP_FORMAT_RGBA_8888);
 
-  JavaBitmap src_lock(jbitmap.obj());
-  DCHECK_EQ(src_lock.format(), ANDROID_BITMAP_FORMAT_RGBA_8888);
-
-  gfx::Size src_size = src_lock.size();
+  gfx::Size src_size = jbitmap.size();
 
   SkBitmap skbitmap;
   skbitmap.setConfig(SkBitmap::kARGB_8888_Config,
-      src_size.width(), src_size.height(), src_lock.stride());
+                     src_size.width(),
+                     src_size.height(),
+                     jbitmap.stride());
   skbitmap.allocPixels();
   SkAutoLockPixels dst_lock(skbitmap);
 
-  void* src_pixels = src_lock.pixels();
+  void* src_pixels = jbitmap.pixels();
   void* dst_pixels = skbitmap.getPixels();
 
   memcpy(dst_pixels, src_pixels, skbitmap.getSize());
 
   return skbitmap;
 }
 
+static SkBitmap ConvertToSkBitmap(ScopedJavaLocalRef<jobject> jbitmap) {

[aelias_OOO_until_Jul13, 2013/09/06 04:17:38]

Could you get rid of this method by making CreateJavaBitmapFromResource return a
JavaBitmap instead?

[powei, 2013/09/09 17:57:18]

Done.  Consolidated into fewer functions.

+  if (jbitmap.is_null())
+    return SkBitmap();
+
+  JavaBitmap src_lock(jbitmap.obj());
+  return CreateSkBitmapFromJavaBitmap(src_lock);
+}
+
 SkBitmap CreateSkBitmapFromResource(const char* name, gfx::Size size) {
   DCHECK(!size.IsEmpty());
   SkBitmap bitmap =
       ConvertToSkBitmap(CreateJavaBitmapFromResource(name, size));
   if (bitmap.isNull())
     return bitmap;
   // RESIZE_BOX has sufficient downsampling quality with minimal runtime cost.
   return skia::ImageOperations::Resize(bitmap,
                                        skia::ImageOperations::RESIZE_BOX,
                                        size.width(), size.height());
 }
 
 }  //  namespace gfx