|
|
Description[Material][Mac] Update the User Account Button
BUG=590917
Committed: https://crrev.com/1f0a7bb629f3ad9464aba375a20a59e5d23ca23b
Cr-Commit-Position: refs/heads/master@{#416382}
Patch Set 1 #Patch Set 2 : nit #Patch Set 3 : add .icon file #Patch Set 4 : Rebased and fixed conflicts #Patch Set 5 : Pixel pushing #Patch Set 6 : Increase icon size #Patch Set 7 : fixed test #
Messages
Total messages: 38 (18 generated)
Description was changed from ========== [Material][Mac] Update the User Account Button BUG=590917 ========== to ========== [Material][Mac] Update the User Account Button BUG=590917 ==========
spqchan@chromium.org changed reviewers: + shrike@chromium.org
PTAL
Hey spqchan@ - I'm having trouble applying the patch. Does it need to be rebased?
On 2016/08/31 18:35:53, shrike wrote: > Hey spqchan@ - I'm having trouble applying the patch. Does it need to be > rebased? Rebased and fixed conflicts
Hi spqchan@, For whatever reason I cannot log in to test how the button looks when you're logged in. You should go ahead and proceed with landing the change and we'll verify it all looks good in Canary (before cherry-picking back). One small problem I did notice was the icon appears to be too small. On my Retina machine the icon fits in a 28x28 box but looking at the spec in Photoshop the size is 34x34.
On 2016/09/01 00:05:14, shrike wrote: > Hi spqchan@, > > For whatever reason I cannot log in to test how the button looks when you're > logged in. You should go ahead and proceed with landing the change and we'll > verify it all looks good in Canary (before cherry-picking back). > > One small problem I did notice was the icon appears to be too small. On my > Retina machine the icon fits in a 28x28 box but looking at the spec in Photoshop > the size is 34x34. You don't have to log in. You can just add a new profile and it will automatically become "Person 1" Also, according to the specs, the icon should be in a 24x28 box.
spqchan@chromium.org changed reviewers: + avi@chromium.org
+avi for OWNER review
lgtm
On 2016/09/01 19:59:01, Avi wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by spqchan@chromium.org
The CQ bit was checked by spqchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2286993002/#ps100001 (title: "Increase icon size")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2286993002/#ps120001 (title: "fixed test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Material][Mac] Update the User Account Button BUG=590917 ========== to ========== [Material][Mac] Update the User Account Button BUG=590917 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [Material][Mac] Update the User Account Button BUG=590917 ========== to ========== [Material][Mac] Update the User Account Button BUG=590917 Committed: https://crrev.com/1f0a7bb629f3ad9464aba375a20a59e5d23ca23b Cr-Commit-Position: refs/heads/master@{#416382} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/1f0a7bb629f3ad9464aba375a20a59e5d23ca23b Cr-Commit-Position: refs/heads/master@{#416382} |