Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2286993002: [Material][Mac] Update the User Account Button (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Update the User Account Button BUG=590917 Committed: https://crrev.com/1f0a7bb629f3ad9464aba375a20a59e5d23ca23b Cr-Commit-Position: refs/heads/master@{#416382}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : add .icon file #

Patch Set 4 : Rebased and fixed conflicts #

Patch Set 5 : Pixel pushing #

Patch Set 6 : Increase icon size #

Patch Set 7 : fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -36 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 2 3 4 5 8 chunks +87 lines, -33 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 1 2 3 4 5 6 2 chunks +10 lines, -3 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/vector_icons/user_account_avatar.icon View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (18 generated)
spqchan
PTAL
4 years, 3 months ago (2016-08-26 23:42:51 UTC) #3
shrike
Hey spqchan@ - I'm having trouble applying the patch. Does it need to be rebased?
4 years, 3 months ago (2016-08-31 18:35:53 UTC) #4
spqchan
On 2016/08/31 18:35:53, shrike wrote: > Hey spqchan@ - I'm having trouble applying the patch. ...
4 years, 3 months ago (2016-08-31 22:55:03 UTC) #5
shrike
Hi spqchan@, For whatever reason I cannot log in to test how the button looks ...
4 years, 3 months ago (2016-09-01 00:05:14 UTC) #6
spqchan
On 2016/09/01 00:05:14, shrike wrote: > Hi spqchan@, > > For whatever reason I cannot ...
4 years, 3 months ago (2016-09-01 19:49:26 UTC) #7
spqchan
+avi for OWNER review
4 years, 3 months ago (2016-09-01 19:49:56 UTC) #9
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-01 19:59:01 UTC) #10
spqchan
On 2016/09/01 19:59:01, Avi wrote: > lgtm thanks!
4 years, 3 months ago (2016-09-01 20:43:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/80001
4 years, 3 months ago (2016-09-01 20:44:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/100001
4 years, 3 months ago (2016-09-01 21:18:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/289426)
4 years, 3 months ago (2016-09-01 22:51:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/100001
4 years, 3 months ago (2016-09-01 22:55:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/289500)
4 years, 3 months ago (2016-09-02 00:12:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/120001
4 years, 3 months ago (2016-09-02 17:54:50 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/286811)
4 years, 3 months ago (2016-09-02 20:35:24 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/120001
4 years, 3 months ago (2016-09-02 20:41:31 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/286892)
4 years, 3 months ago (2016-09-02 22:08:21 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286993002/120001
4 years, 3 months ago (2016-09-02 22:14:42 UTC) #34
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-02 23:19:27 UTC) #36
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:20:58 UTC) #38
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/1f0a7bb629f3ad9464aba375a20a59e5d23ca23b
Cr-Commit-Position: refs/heads/master@{#416382}

Powered by Google App Engine
This is Rietveld 408576698