Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2286963002: DevTools: Turn *Model events into symbols (Closed)
Patch Set: Add SourcesTextEditor events Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.Object} 9 * @extends {WebInspector.Object}
10 */ 10 */
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 } 255 }
256 var copy = this._observersForTarget(target); 256 var copy = this._observersForTarget(target);
257 for (var i = 0; i < copy.length; ++i) 257 for (var i = 0; i < copy.length; ++i)
258 copy[i].targetAdded(target); 258 copy[i].targetAdded(target);
259 259
260 for (var pair of this._modelListeners) { 260 for (var pair of this._modelListeners) {
261 var listeners = pair[1]; 261 var listeners = pair[1];
262 for (var i = 0; i < listeners.length; ++i) { 262 for (var i = 0; i < listeners.length; ++i) {
263 var model = target.model(listeners[i].modelClass); 263 var model = target.model(listeners[i].modelClass);
264 if (model) 264 if (model)
265 model.addEventListener(pair[0], listeners[i].listener, liste ners[i].thisObject); 265 model.addEventListener(/** @type {symbol} */ (pair[0]), list eners[i].listener, listeners[i].thisObject);
266 } 266 }
267 } 267 }
268 268
269 /** 269 /**
270 * @param {!WebInspector.ResourceTreeModel.Events} sourceEvent 270 * @param {!WebInspector.ResourceTreeModel.Events} sourceEvent
271 * @param {!WebInspector.TargetManager.Events} targetEvent 271 * @param {!WebInspector.TargetManager.Events} targetEvent
272 * @return {!WebInspector.EventTarget.EventDescriptor} 272 * @return {!WebInspector.EventTarget.EventDescriptor}
273 * @this {WebInspector.TargetManager} 273 * @this {WebInspector.TargetManager}
274 */ 274 */
275 function setupRedispatch(sourceEvent, targetEvent) 275 function setupRedispatch(sourceEvent, targetEvent)
(...skipping 15 matching lines...) Expand all
291 291
292 var copy = this._observersForTarget(target); 292 var copy = this._observersForTarget(target);
293 for (var i = 0; i < copy.length; ++i) 293 for (var i = 0; i < copy.length; ++i)
294 copy[i].targetRemoved(target); 294 copy[i].targetRemoved(target);
295 295
296 for (var pair of this._modelListeners) { 296 for (var pair of this._modelListeners) {
297 var listeners = pair[1]; 297 var listeners = pair[1];
298 for (var i = 0; i < listeners.length; ++i) { 298 for (var i = 0; i < listeners.length; ++i) {
299 var model = target.model(listeners[i].modelClass); 299 var model = target.model(listeners[i].modelClass);
300 if (model) 300 if (model)
301 model.removeEventListener(pair[0], listeners[i].listener, li steners[i].thisObject); 301 model.removeEventListener(/** @type {symbol} */ (pair[0]), l isteners[i].listener, listeners[i].thisObject);
302 } 302 }
303 } 303 }
304 }, 304 },
305 305
306 /** 306 /**
307 * @param {number=} capabilitiesMask 307 * @param {number=} capabilitiesMask
308 * @return {!Array.<!WebInspector.Target>} 308 * @return {!Array.<!WebInspector.Target>}
309 */ 309 */
310 targets: function(capabilitiesMask) 310 targets: function(capabilitiesMask)
311 { 311 {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 /** 376 /**
377 * @param {!WebInspector.Target} target 377 * @param {!WebInspector.Target} target
378 */ 378 */
379 targetRemoved: function(target) { }, 379 targetRemoved: function(target) { },
380 } 380 }
381 381
382 /** 382 /**
383 * @type {!WebInspector.TargetManager} 383 * @type {!WebInspector.TargetManager}
384 */ 384 */
385 WebInspector.targetManager = new WebInspector.TargetManager(); 385 WebInspector.targetManager = new WebInspector.TargetManager();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698