Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2286963002: DevTools: Turn *Model events into symbols (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Turn *Model events into symbols Committed: https://crrev.com/0f97e6f1d883e094b4fd92da0b255226647b7053 Cr-Commit-Position: refs/heads/master@{#414876}

Patch Set 1 #

Patch Set 2 : Add SourcesTextEditor events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -155 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-2-expected.txt View 9 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-expected.txt View 10 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-for-xhtml-expected.txt View 10 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/undo-set-outer-html-2-expected.txt View 10 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/undo-set-outer-html-expected.txt View 10 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alph
4 years, 3 months ago (2016-08-26 21:30:17 UTC) #2
lushnikov
lgtm! Are these the last string events? Can we also move the type in WI.Object.addEventListener ...
4 years, 3 months ago (2016-08-26 22:21:21 UTC) #5
alph
On 2016/08/26 22:21:21, lushnikov wrote: > lgtm! > > Are these the last string events? ...
4 years, 3 months ago (2016-08-26 22:31:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286963002/20001
4 years, 3 months ago (2016-08-26 22:40:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 00:24:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 00:27:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f97e6f1d883e094b4fd92da0b255226647b7053
Cr-Commit-Position: refs/heads/master@{#414876}

Powered by Google App Engine
This is Rietveld 408576698